[IMP] stock_release_channel_process_end_time: freeze_schedule_date option #19
Conversation
|
Hi @rousseldenis, could you take a look this issue when you have a chance, thanks |
| @@ -69,6 +69,9 @@ def _after_release_set_expected_date(self): | |||
| rec.release_channel_id | |||
| and rec.release_channel_id.process_end_date | |||
| and rec.scheduled_date != rec.release_channel_id.process_end_date | |||
| # freeze scheduled_date in some cases don't need to change scheduled_date | |||
| # like in the test environemnt | |||
| and not self.env.context.get('freeze_scheduled_date') | |||
There was a problem hiding this comment.
@anothingguy Nope. Introducing something only for tests is bad.
Instead, I would have added a configuration parameter boolean in release channel configuration to enable the date change at release.
So, in tests, this can be tested with and without the feature.
There was a problem hiding this comment.
I've just added a configuration parameter boolean in release channel configuration instead of using context
There was a problem hiding this comment.
Hi @rousseldenis, could you take a look at it since it's breaking the tests in stock_available_to_promise_release module
There was a problem hiding this comment.
Yes.
But where is it broken as 16.0 branch is green ?
There was a problem hiding this comment.
yes, it's broken the tests here in my module which needs to depends on stock_release_channel_process_end_time. I'm not sure why your tests was green previous time, but I did run the tests with your module in the local and failed as well. seems odd.
anothingguy
force-pushed
the
16.0-release_channel_date_freeze_schedule_date
branch
from
db07e38
to
c9fcf19
Compare
Codecov Report
@@ Coverage Diff @@
## 16.0-release_channel_date-dro #19 +/- ##
================================================================
Coverage ? 95.79%
================================================================
Files ? 53
Lines ? 2428
Branches ? 221
================================================================
Hits ? 2326
Misses ? 73
Partials ? 29 |
rousseldenis
merged commit da2138b
into
acsone:16.0-release_channel_date-dro
running the test cases for OCA#750 failed because
stock_release_channel_process_end_timeextended method_after_release_set_expected_dateto changescheduled_datewhich makes test case instock_available_to_promise_releasefailed: link.It's useful to add
freeze_scheduled_datein context to freeze it for some special cases