-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Metadata in glossary #1085
Metadata in glossary #1085
Conversation
Are we supposed to be using these attributes to be shown somewhere on the website? |
As far as I understand, "not now". Currently, we just add them and hope that rule authors/reviewers will think about them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of ones I disagree with.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly seems fine. Agree with most of Wilco's comments and added one or two of my own.
Add "unambiguous" and "objective" metadata in each definition.
Co-authored by @JKODU
Closes issue(s):
Need for Final Call:
This will not require a Final Call (internal metadata with no external visibility).
Pull Request Etiquette
When creating PR:
develop
branch (left side).After creating PR:
Rule
,Definition
orChore
.How to Review And Approve