New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Heading is descriptive" (b49b2e): replace "section of content" #1425
Conversation
_rules/heading-descriptive-b49b2e.md
Outdated
- [visible][], if the target is [visible][]; and | ||
- [included in the accessibility tree][], if the target is [included in the accessibility tree][]. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This strongly suggest that this rule should be split in two, one for each case…
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not if those 'and' conditional are intentional. I read this as:
If the target is visible and included in the accessibility tree, then it should describe the first palpable content that is visible and included in the accessibility tree that comes after the target in the flat tree.
However, what about non-visible headings describing visible content, where both are included in the accessibility tree? This is not an unusual use case, eg. a news front page with a hidden heading 'Top headlines'. The heading isn't needed visually as that is usually apparent from other cues.
That also makes me question the phrasing of the applicability. Should it not be ' visible and/or included in the accessibility tree'?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it is both visible and included in the accessibility tree, then it is "visible or included in the accessibility tree" (the or is inclusive by default). And then it matches both the expectations and need to describe both visible and accessible content (which may be the same or different palpable content).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it! 👏
|
||
**Note:** Headings do not need to be lengthy. A word, or even a single character, may suffice. | ||
|
||
## Assumptions | ||
|
||
This rule assumes that the language of each test target can be correctly determined (either programmatically or by analyzing the content), and sufficiently understood. | ||
- This rule assumes that the language of each test target can be correctly determined (either programmatically or by analyzing the content), and sufficiently understood. | ||
- This rule assumes that the [flat tree][] order is close to the reading order, as elements are rendered on the page. Due to positioning, it is possible to render a document in a order that greatly differ from the tree order, in which case the content which is visually associated with a heading might not be the content following it in tree order and this rule might fail while [Success Criterion 2.4.6 Headings and Label][sc246] is still satisfied. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't the rule essentially assuming conformance to 1.3.2 (https://www.w3.org/TR/WCAG/#meaningful-sequence)? In that case, it seems like an even more reasonable assumption to make.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not really, because the programmatically determined order could be different from the DOM order (and match the visual order). For example by tweaking the accessibility tree with aria-owns
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense 👍 I also just looked into CSS Grid and, interestingly enough, grid layouts that re-arrange the logical order of content are non-conforming: https://drafts.csswg.org/css-grid/#order-accessibility
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not to mention the fun that can ensue when flexbox gets involved!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think some fine tuning is still needed with the phrasing of the applicability and expectation sections. Other than that, I think this is really starting to shape up well.
Split expectation in two
Co-authored-by: Aron Janecki <aronjanecki@gmail.com>
Co-authored-by: Aron Janecki <aronjanecki@gmail.com>
Final Call ends on September 23rd. |
Final Call has ended. Merging. |
Change the expectation to remove "section of content" and replace it with "the next palpable content" (according to https://www.w3.org/2020/07/23-act-r-minutes.html#item01).
Doing minimal changes to get the fix working. Notably not splitting the rule for visible/accessible headings (it feels much needed now), and not cleaning up the rest of the rule (will be done once we want to submit it to TF review).
Closes issue(s):
Need for Final Call:
This will require a 1 week Final Call (changing expectation)
Pull Request Etiquette
When creating PR:
develop
branch (left side).After creating PR:
Rule
,Definition
orChore
.When merging a PR:
How to Review And Approve