Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WiP] "role attribute has valid value" for focusable elements draft #1454

Closed
wants to merge 1 commit into from

Conversation

Jym77
Copy link
Collaborator

@Jym77 Jym77 commented Sep 21, 2020

Drafting a rule for "role attribute has valid value" specialised on focusable elements that can be considered as UI components and thus maps to 4.1.2

Closes issue(s):

  • N/A

Need for Final Call:
This will require a 2 weeks Final Call (new rule)


Pull Request Etiquette

When creating PR:

  • Make sure you're requesting to pull a branch (right side) to the develop branch (left side).

After creating PR:

  • Add yourself (and co-authors) as "Assignees" for PR.
  • Add label to indicate if it's a Rule, Definition or Chore.
  • Link the PR to any issue it solves. This will be done automatically by referencing the issue at the top of this comment in the indicated place.
  • Optionally request feedback from anyone in particular by assigning them as "Reviewers".

When merging a PR:

  • Close any issue that the PR resolves. This will happen automatically upon merging if the PR was correctly linked to the issue, e.g. by referencing the issue at the top of this comment.

How to Review And Approve

  • Go to the “Files changed” tab
  • Here you will have the option to leave comments on different lines.
  • Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.
  • Make sure to also review the proposed Final Call period. In case of disagreement, the longer period wins.

@Jym77 Jym77 changed the title [WiP] "role attribute has valid value" for focusable elements [WiP] "role attribute has valid value" for focusable elements draft Sep 23, 2020
Copy link
Member

@WilcoFiers WilcoFiers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks promising.

@Jym77
Copy link
Collaborator Author

Jym77 commented Feb 1, 2021

Closing since this is not necessary after #1537.

@Jym77 Jym77 closed this Feb 1, 2021
@Jym77 Jym77 deleted the focusable-role-valid branch February 1, 2021 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants