"role attribute has valid value" (674b10): map to 1.3.1

[Jym77]

After CG call on 14/01/2021, we decided to map the "role attribute has valid value" rule to 1.3.1 with an assumption that a role attribute implies some styling to make the element look like it should.
See https://github.com/act-rules/act-rules.github.io/wiki/Minutes-2021-01-14#what-to-do-of-role-attribute-has-valid-value

I'm not super happy with the examples which are poor authoring practices 🤷

Closes issue(s):

• closes What to do of "role attribute has valid value"? #1496

Need for Final Call:
This will require a 1 week Final Call (updating mappings and examples)

---

Pull Request Etiquette

When creating PR:

• Make sure you're requesting to pull a branch (right side) to the develop branch (left side).
• Make sure you do not remove the "How to Review and Approve" section in your pull request description

After creating PR:

• Add yourself (and co-authors) as "Assignees" for PR.
• Add label to indicate if it's a Rule, Definition or Chore.
• Link the PR to any issue it solves. This will be done automatically by referencing the issue at the top of this comment in the indicated place.
• Optionally request feedback from anyone in particular by assigning them as "Reviewers".

When merging a PR:

• Close any issue that the PR resolves. This will happen automatically upon merging if the PR was correctly linked to the issue, e.g. by referencing the issue at the top of this comment.

How to Review And Approve

• Go to the “Files changed” tab
• Here you will have the option to leave comments on different lines.
• Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.
• Make sure to also review the proposed Final Call period. In case of disagreement, the longer period wins.

[kasperisager]

I'm on board 👍

Changes done.

[Jym77]

Final Call ends on January 28th.

[WilcoFiers]

I think this is an example of where that third assumption might be true. Without the role attribute, this would be a perfectly valid form field.

[Jym77]

I would argue that the correct (and definitely the intended) role is here searchbox, so the third assumption still holds. (and this is indicated by the "Search" label).

[WilcoFiers]

I don't much like this example. I don't think button is a particularly appropriate role for this. I think we should show an appropriate use of fallback roles if we want them demonstrated. Maybe use on of the DPUB roles, with link as a fallback?

[Jym77]

I don't know what this example was supposed to show (I've only added the styling), but I definitely like the DPUB idea 😀

[Elli360]

Looks at this resource - https://zellwk.com/blog/style-hover-focus-active-states/

Changes done

[Jym77]

Final Call has ended. Merging.