Clarify 'one of the following' phrases #1659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WilcoFiers
requested review from
carlosapaduarte,
Jym77,
ajanec01 and
daniel-montalvo
Jym77
approved these changes
Jun 24, 2021
| @@ -163,7 +163,7 @@ Applicability and expectations, often have multiple conditions that need to be m | |||
|
|
|||
| This phrasing is designed to be easily readable, but may not work in every situation. In all cases prefer readability over prescriptive formatting. Additionally to this, keep the following in mind when listing conditions: | |||
|
|
|||
| - The phrasing "for which (all | one of) the following is" can be modified based on use, such as "to achieve one of the following objectives". | |||
| - The phrasing "for which (all | at least one of) the following is" can be modified based on use, such as "to achieve at least one of the following objectives". | |||
There was a problem hiding this comment.
Should we mention here the "except if one or more of the following" construction?
carlosapaduarte
approved these changes
Jun 25, 2021
ajanec01
approved these changes
Jun 27, 2021
WilcoFiers
added
the
Review call 2 weeks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I used "at least one of the following" in phrases where the outcome is something desirable. It seemed a little odd to say "except if at least one... " so I used "one ore more" in a few cases where "at least" seemed out of place.
Need for Final Call: 2 weeks. This change touches a large number of rules.
How to Review And Approve