-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated examples to ensure tests are case insensitive in valid lang tag rules #1775
Updated examples to ensure tests are case insensitive in valid lang tag rules #1775
Conversation
…subtag are done in a case insensitive manner
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not fully sure whether we should instead add new passed example (with appropriate description pointing on case insensitivity).
Mostly because these examples probably already exist for a reason (at least I hope) and that they now have 2 reasons: the old one and the case insensitivity; which we normally frown upon.
The definition of valid language tag already includes this:
Do you really think that we need to have tests exclusively checking this? |
…anguate-tag-rules
…anguate-tag-rules
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@carlosapaduarte can you change the PR title of this, so we end up with a complete message in the changelog?
…anguate-tag-rules
…anguate-tag-rules
…anguate-tag-rules
Call for review ends on February 18 |
…anguate-tag-rules
Call for review ended. Merging |
…subtag are done in a case insensitive manner
Closes issue(s):
Need for Call for Review:
This will require a 1 week Call for Review
How to Review And Approve