Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated examples to ensure tests are case insensitive in valid lang tag rules #1775

Conversation

carlosapaduarte
Copy link
Member

…subtag are done in a case insensitive manner

Closes issue(s):

Need for Call for Review:
This will require a 1 week Call for Review


How to Review And Approve

  • Go to the “Files changed” tab
  • Here you will have the option to leave comments on different lines.
  • Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.
  • Make sure to also review the proposed Call for Review period. In case of disagreement, the longer period wins.

…subtag are done in a case insensitive manner
@carlosapaduarte carlosapaduarte added the Rule Update Use this label for an existing rule that is being updated label Dec 27, 2021
@carlosapaduarte carlosapaduarte self-assigned this Dec 27, 2021
Jym77
Jym77 previously requested changes Jan 10, 2022
Copy link
Collaborator

@Jym77 Jym77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not fully sure whether we should instead add new passed example (with appropriate description pointing on case insensitivity).
Mostly because these examples probably already exist for a reason (at least I hope) and that they now have 2 reasons: the old one and the case insensitivity; which we normally frown upon.

@carlosapaduarte
Copy link
Member Author

The definition of valid language tag already includes this:

Subtags, notably the primary language subtag, are case insensitive. Hence comparison with the language subtag registry must be done in a case insensitive way.

Do you really think that we need to have tests exclusively checking this?

Copy link
Member

@WilcoFiers WilcoFiers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@carlosapaduarte can you change the PR title of this, so we end up with a complete message in the changelog?

@carlosapaduarte carlosapaduarte changed the title updated passed examples to ensure test checking the primary language … Updated examples to ensure tests are case insensitive in valid lang tag rules Jan 28, 2022
@carlosapaduarte carlosapaduarte added the Review Call 1 week Call for review for small changes label Feb 11, 2022
@carlosapaduarte
Copy link
Member Author

Call for review ends on February 18

@carlosapaduarte
Copy link
Member Author

Call for review ended. Merging

@carlosapaduarte carlosapaduarte merged commit a454859 into develop Feb 24, 2022
@carlosapaduarte carlosapaduarte deleted the update-capitalization-examples-in-valid-languate-tag-rules branch February 24, 2022 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Review Call 1 week Call for review for small changes reviewers wanted Rule Update Use this label for an existing rule that is being updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add test case with different capitalization in valid language tag rules (de46e4 and bf051a)
5 participants