Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add note to button has accessible name rule to explain the exception #97a4e1 #1821

Merged
merged 4 commits into from
May 30, 2022
Merged

Add note to button has accessible name rule to explain the exception #97a4e1 #1821

merged 4 commits into from
May 30, 2022

Conversation

carlosapaduarte
Copy link
Member

The CG decided to add a note explaining the reason for the image buttons exception in the button has non-empty accessible name rule.

Need for Call for Review:
This will require a 1 week Call for Review

How to Review And Approve

  • Go to the “Files changed” tab
  • Here you will have the option to leave comments on different lines.
  • Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.
  • Make sure to also review the proposed Call for Review period. In case of disagreement, the longer period wins.

@carlosapaduarte carlosapaduarte added Rule Update Use this label for an existing rule that is being updated reviewers wanted labels Mar 25, 2022
@carlosapaduarte carlosapaduarte self-assigned this Mar 25, 2022
@carlosapaduarte
Copy link
Member Author

Call for review ends May 23

@carlosapaduarte carlosapaduarte added Review Call 1 week Call for review for small changes and removed reviewers wanted labels May 13, 2022
@carlosapaduarte
Copy link
Member Author

Call for review ended. Merging.

@carlosapaduarte carlosapaduarte merged commit e868c31 into develop May 30, 2022
@carlosapaduarte carlosapaduarte deleted the add-note-to-button-has-accessible-name branch May 30, 2022 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WilcoFiers WilcoFiers WilcoFiers approved these changes

@Jym77 Jym77 Jym77 approved these changes

@colabottles colabottles colabottles approved these changes

@HelenBurge HelenBurge HelenBurge approved these changes

@daniel-montalvo daniel-montalvo Awaiting requested review from daniel-montalvo

Assignees

@carlosapaduarte carlosapaduarte

Labels
Review Call 1 week Call for review for small changes Rule Update Use this label for an existing rule that is being updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@carlosapaduarte @WilcoFiers @Jym77 @colabottles @HelenBurge