Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Video element auditory content has captions" [f51b46]: Adding 1.2.1 as a secondary requirement. #2089

Merged
merged 4 commits into from
Oct 23, 2023

Conversation

tbostic32
Copy link
Collaborator

Adding 1.2.1 as a secondary requirement.

TF review sheet link (note many of the comments here are out of date)

Closes issue(s):

  • closes #XXX (ADD ISSUE NUMBER HERE)

Need for Call for Review:
This will not require a Call for Review

How to Review And Approve

  • Go to the “Files changed” tab
  • Here you will have the option to leave comments on different lines.
  • Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.
  • Make sure to also review the proposed Call for Review period. In case of disagreement, the longer period wins.

@@ -20,6 +20,8 @@ accessibility_requirements:
failed: not satisfied
passed: further testing needed
inapplicable: further testing needed
wcag20:1.2.1: # Audio-only and Video-only (Prerecorded) (A)
secondary: true
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
secondary: true
secondary: Because this rule does not consider that the video may be a media alternative for text, it is stricter than the requirement. Failing this rule often results in this success criterion being not satisfied.

Or something like that.

Using https://github.com/act-rules/act-rules.github.io/pull/2060/files as a guide.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed this text to be the same was what we ended up deciding in the 2060 PR.

@Jym77 Jym77 changed the title Adding 1.2.1 as a secondary requirement. "Video element auditory content has captions" [f51b46]: Adding 1.2.1 as a secondary requirement. Aug 10, 2023
@tbostic32 tbostic32 requested a review from Jym77 August 31, 2023 12:28
@WilcoFiers
Copy link
Member

@tbostic32 I do think this needs a call for review. Please update that part of it.

@Jym77 Jym77 added the Review Call 1 week Call for review for small changes label Oct 16, 2023
@tbostic32 tbostic32 merged commit f43ec35 into develop Oct 23, 2023
2 checks passed
@tbostic32 tbostic32 deleted the tbostic/video-captions branch October 23, 2023 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Review Call 1 week Call for review for small changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants