New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Text has minimum contrast" [afw4f7] and "Text has enhanced contrast" [09o5cg]: updated scenario for non-text content #2155
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In particular I like how you changed the enhanced example's colors so that they pass the minimum rule and fail the enhanced rule.
Looks good. Not approving since there is already one approval from Siteimprove. |
Call for review ends on February 21st. |
@giacomo-petri I seem to be unable to solve the merge conflict myself since the PR is on a fork. Can you fix it (update the |
Hi @Jym77, |
🤔 It looks like I did in fact manage to resolve the merge conflict… |
Call for Review has ended, merging. |
The current example in Text has minimum contrast and Text has enhanced contrast "----=====++++++++___________***********%%%%%%%%%%%±±±±@@@@@@@@" does not depict a realistic scenario.
I have updated the example by incorporating a button featuring an "X" symbol to enhance clarity regarding the specific test's intention. Additionally, I have included a reference to 1.4.11 Non-Text content for further tests.
Closes issue(s):
X
for close? #2132Need for Call for Review:
This will require a 1 week Call for Review
Pull Request Etiquette
When creating PR:
develop
branch (left side).After creating PR:
Rule
,Definition
orChore
.When merging a PR:
How to Review And Approve