-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rule: Headers attribute only refers to cells in the same table (a25f45) #412
Conversation
headers
attribute
headers
attributeheaders
attribute
headers
attributeThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor requests for change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from the comment Wilco left about included in the accessibility tree I approve this rule.
<th id="headerOfColumn">Projects</th> | ||
</tr> | ||
<tr> | ||
<td headers="elmOutsideTable">15%</td> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Every screen reader we've tested this in will look at row/column headers for fallback. That may not be what the algorithm says they should do, but someone testing with one of the top 4 AT / browser combinations is not going to see a problem here. I find this test case questionable. Here's the test case we ran a little while ago:
<table>
<tr>
<th scope="col">Projects</th>
<th scope="col">Progress</th>
</tr>
<tr>
<td headers="projects100">My Project</td>
<td>15%</td>
</tr>
</table>
IE + JAWS: Works
Chrome + JAWS: Works
Firefox + NVDA: Works
Safari + VO: Works
<th id="headerOfColumn">Projects</th> | ||
</tr> | ||
<tr> | ||
<td headers="elmOutsideTable">15%</td> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this passes the SC (which I don't challenge), then the rule need to be changed to take fallback headers into account.
This certainly fails the rule right now, so if this passes the SC, the rule is bad.
And the rule in its current version is not referencing the assignation algorithm anymore…
(technically, the rule does assume that there is no fallback headers, but if this assumption is false for the vaste majority of cases, it needs to go away)
…les.github.io into rule-table-headers-attr
Given the changes to the examples, I am adding another 1 week to this PR for final call, which will end on 24th Feb 2020 |
Rule:
headers
attribute only refers tocells
in the sametable
Closes issue: #406
Note:
For clear intents and purposes, the scope of this rule is kept to be fairly simple.
Intent is to author more rules for various other scenarios that involves this SC.