Code style fixes (#338)

* Fix minor spelling in allDelayed comments

* Simplify instanceof Array expressions

* Remove duplicate declaration

* Update imports in examples to short form

Use unified style, and comment block for easier comment removal

* Simplify import of internal modules

__tests__/core/connection.ts

@@ -1,5 +1,5 @@
 import * as Ioredis from "ioredis";
-import { Connection } from "../../src/index";
+import { Connection } from "../../src";
 import specHelper from "../utils/specHelper";
 
 describe("connection", () => {

__tests__/core/multiWorker.ts

@@ -1,5 +1,5 @@
 import specHelper from "../utils/specHelper";
-import { MultiWorker, Queue } from "../../src/index";
+import { MultiWorker, Queue } from "../../src";
 
 let queue;
 let multiWorker;

__tests__/core/queue.ts

@@ -1,4 +1,4 @@
-import { Queue, Worker } from "../../src/index";
+import { Queue, Worker } from "../../src";
 import specHelper from "../utils/specHelper";
 let queue;
 

__tests__/core/scheduler.ts

@@ -1,4 +1,4 @@
-import { Queue, Scheduler, Worker } from "../../src/index";
+import { Queue, Scheduler, Worker } from "../../src";
 import specHelper from "../utils/specHelper";
 
 let scheduler;

__tests__/core/worker.ts

@@ -1,4 +1,4 @@
-import { Queue, Worker } from "../../src/index";
+import { Queue, Worker } from "../../src";
 import specHelper from "../utils/specHelper";
 
 const jobs = {

__tests__/plugins/custom_plugins.ts

@@ -1,5 +1,5 @@
 import specHelper from "../utils/specHelper";
-import { Queue } from "../../src/index";
+import { Queue } from "../../src";
 import { CustomPlugin } from "../utils/custom-plugin";
 
 describe("plugins", () => {

__tests__/plugins/delayedQueueLock.ts

@@ -1,5 +1,5 @@
 import specHelper from "../utils/specHelper";
-import { Plugin, Queue, Worker } from "../../src/index";
+import { Plugin, Queue, Worker } from "../../src";
 
 let queue;
 const jobDelay = 100;

__tests__/plugins/jobLock.ts

@@ -1,5 +1,5 @@
 import specHelper from "../utils/specHelper";
-import { Queue, Worker } from "../../src/index";
+import { Queue, Worker } from "../../src";
 
 let queue;
 const jobDelay = 1000;

__tests__/plugins/noop.ts

@@ -1,5 +1,5 @@
 import specHelper from "../utils/specHelper";
-import { Scheduler, Queue, Worker } from "../../src/index";
+import { Scheduler, Queue, Worker } from "../../src";
 
 let queue;
 let scheduler;

__tests__/plugins/queueLock.ts

@@ -1,5 +1,5 @@
 import specHelper from "../utils/specHelper";
-import { Plugin, Queue, Worker } from "../../src/index";
+import { Plugin, Queue, Worker } from "../../src";
 
 let queue;
 

__tests__/plugins/retry.ts

@@ -1,5 +1,5 @@
 import specHelper from "../utils/specHelper";
-import { Scheduler, Queue, Worker } from "../../src/index";
+import { Scheduler, Queue, Worker } from "../../src";
 
 let queue;
 let scheduler;

__tests__/utils/custom-plugin.ts

@@ -1,5 +1,5 @@
 // Simple plugin to prevent all jobs
-import { Plugin } from "./../../src/index";
+import { Plugin } from "../../src";
 
 export class CustomPlugin extends Plugin {
   async beforeEnqueue() {

examples/customPluginExample.ts

@@ -1,7 +1,9 @@
 #!/usr/bin/env ts-node
 
-import { Plugin, Worker, Queue } from "./../src/index";
-// In your projects: import { Worker, Scheduler, Queue } from "node-resque";
+import { Plugin, Worker, Queue } from "../src";
+/* In your projects:
+import { Worker, Scheduler, Queue } from "node-resque";
+*/
 
 // ////////////////////////
 // SET UP THE CONNECTION //

examples/docker/producer/producer.js

@@ -1,4 +1,8 @@
-const { Queue } = require("node-resque");
+import { Queue } from "../../../src";
+/* In your projects:
+import { Queue } from require("node-resque");
+*/
+
 let queue;
 
 async function boot() {

examples/docker/worker/worker.js

@@ -1,4 +1,7 @@
+import { Worker, Scheduler } from "../../../src";
+/* In your projects:
 const { Worker, Scheduler } = require("node-resque");
+*/
 
 let worker;
 let scheduler;

examples/errorExample.ts

@@ -1,7 +1,9 @@
 #!/usr/bin/env ts-node
 
-import { Queue, Worker } from "./../src/index";
-// In your projects: import { Worker, Scheduler, Queue } from "node-resque";
+import { Queue, Worker } from "../src";
+/* In your projects:
+import { Queue, Worker } from "node-resque";
+*/
 
 // ////////////////////////
 // SET UP THE CONNECTION //

examples/example.ts

@@ -1,7 +1,9 @@
 #!/usr/bin/env ts-node
 
-import { Queue, Scheduler, Worker } from "./../src/index";
-// In your projects: import { Worker, Scheduler, Queue } from "node-resque";
+import { Queue, Scheduler, Worker } from "../src";
+/* In your projects:
+import { Queue, Scheduler, Worker } from "node-resque";
+*/
 
 async function boot() {
   // ////////////////////////

examples/multiWorker.ts

@@ -1,7 +1,9 @@
 #!/usr/bin/env ts-node
 
-import { MultiWorker, Queue } from "./../src/index";
-// In your projects: import { Worker, Scheduler, Queue } from "node-resque";
+import { MultiWorker, Queue } from "../src";
+/* In your projects:
+import { MultiWorker, Queue } from "node-resque";
+*/
 
 const connectionDetails = {
   pkg: "ioredis",

examples/performInline.ts

@@ -1,7 +1,9 @@
 #!/usr/bin/env ts-node
 
-import { Worker } from "./../src/index";
-// In your projects: import { Worker, Scheduler, Queue } from "node-resque";
+import { Worker } from "../src";
+/* In your projects:
+import { Worker } from "node-resque";
+*/
 
 // ////////////////////////
 // SET UP THE CONNECTION //

examples/retry.ts

@@ -1,7 +1,9 @@
 #!/usr/bin/env ts-node
 
-import { Queue, Scheduler, Worker } from "./../src/index";
-// In your projects: import { Worker, Scheduler, Queue } from "node-resque";
+import { Queue, Scheduler, Worker } from "../src";
+/* In your projects:
+import { Queue, Scheduler, Worker } from "node-resque";
+*/
 
 // ////////////////////////
 // SET UP THE CONNECTION //

examples/scheduledJobs.ts

@@ -1,10 +1,12 @@
 #!/usr/bin/env ts-node
 
-// In your projects: import { Worker, Scheduler, Queue } from "node-resque";
 // We'll use https://github.com/tejasmanohar/node-schedule for this example,
-// but there are many other excelent node scheduling projects
+// but there are many other excellent node scheduling projects
 import * as schedule from "node-schedule";
-import { Queue, Scheduler, Worker } from "./../src/index";
+import { Queue, Scheduler, Worker } from "../src";
+/* In your projects:
+import { Queue, Scheduler, Worker } from "node-resque";
+*/
 
 // ////////////////////////
 // SET UP THE CONNECTION //

examples/stuckWorker.ts

@@ -1,7 +1,9 @@
 #!/usr/bin/env ts-node
 
-import { Queue, Scheduler, Worker } from "./../src/index";
-// In your projects: import { Worker, Scheduler, Queue } from "node-resque";
+import { Queue, Scheduler, Worker } from "../src";
+/* In your projects:
+import { Queue, Scheduler, Worker } from "node-resque";
+*/
 
 async function boot() {
   // ////////////////////////

src/core/queue.ts

@@ -262,7 +262,7 @@ export class Queue extends EventEmitter {
   }
 
   /**
-   * - jobsHash is an object with its keys being timestamps, and the vales are arrays of jobs at each time.
+   * - jobsHash is an object with its keys being timestamps, and the values are arrays of jobs at each time.
    * - note that this operation can be very slow and very ram-heavy
    */
   async allDelayed() {

src/core/worker.ts

@@ -65,7 +65,7 @@ export declare interface Worker {
   once(event: "ping", cb: (time: number) => void): this;
   once(
     event: "job",
-    cb: (queue: string, job: Job<any> | Job<any> | JobEmit) => void
+    cb: (queue: string, job: Job<any> | JobEmit) => void
   ): this;
   once(
     event: "reEnqueue",
@@ -276,7 +276,7 @@ export class Worker extends EventEmitter {
       }
 
       let callableArgs = [job.args];
-      if (job.args === undefined || job.args instanceof Array === true) {
+      if (job.args === undefined || job.args instanceof Array) {
         callableArgs = job.args;
       }
 
@@ -329,7 +329,7 @@ export class Worker extends EventEmitter {
     if (!args) {
       args = [];
     }
-    if (args !== undefined && args !== null && args instanceof Array !== true) {
+    if (!(args instanceof Array)) {
       args = [args];
     }