Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix remaning->remaining typo #377

Merged
merged 1 commit into from May 25, 2020
Merged

Fix remaning->remaining typo #377

merged 1 commit into from May 25, 2020

Conversation

glensc
Copy link
Contributor

@glensc glensc commented May 25, 2020

I've kept mis-spelling variant remaningAttempts argument to reEnqueue for backward compatibility.

node-resque doesn't use the argument, but that event consumers might.

@evantahler
Copy link
Member

Thanks!

@evantahler evantahler merged commit 0f6e6c5 into actionhero:master May 25, 2020
@glensc glensc deleted the remaning-typo branch May 26, 2020 07:52
@glensc
Copy link
Contributor Author

glensc commented Aug 16, 2020

for cross-reference, the backward compatible option was removed in 4bad5c9

glensc referenced this pull request Aug 16, 2020
@evantahler
remove depreciated typo emitter
4bad5c9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@glensc @evantahler