add dockerEnabled option #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mumoshu
approved these changes
Nov 16, 2020
There was a problem hiding this comment.
LGTM. Thanks a lot for your continued effort @Warashi!
Note: I initially thought if the new flag is same as DockerdWithinRunnerContainer, but it isn't. DockerWithinRunnerContainer also add priviledges to the runner container, which DockerEnabled doesn't. https://github.com/summerwind/actions-runner-controller/blob/e613219a8980c88977f8231bedbe691b5caa3d9c/controllers/runner_controller.go#L368
|
The new configuration option needs documenting still @Warashi |
|
oh, I forgot to document this feature. |
|
Opened #193 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add dockerEnabled option for users who does not need docker and want not to run privileged container.
if
dockerEnabled == false, dind container not run, and there are no privileged container.Do the same as closed #96