Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support default imagePullSecrets in runner pod for private docker registries #896

Closed
fgalind1 opened this issue Oct 15, 2021 · 2 comments · Fixed by #921
Closed

Support default imagePullSecrets in runner pod for private docker registries #896

fgalind1 opened this issue Oct 15, 2021 · 2 comments · Fixed by #921

Comments

@fgalind1
Copy link
Contributor

fgalind1 commented Oct 15, 2021

Is your feature request related to a problem?.
When using a private docker registry it is required to provide the docker image as a imagePullSecrets in the runner pod spec. Runner pod spec supports imagePullSecrets, however it's quite useful to support this at the controller level with a default value similarly as it's done for runner image

Describe the solution you'd like
In the same way as a cmdline argument is supported to provide --runner-image, I'd like to have an option --runner-image-pull-secret-name or something similar that contains the secret name that holds the docker config and then use that to add the imagePullSecrets in the runner pod with something like:

	if defaultRunnerImagePullSecretName != "" {
		pod.Spec.ImagePullSecrets = []corev1.LocalObjectReference{
			{Name: defaultRunnerImagePullSecretName},
		}
	}

Describe alternatives you've considered
Define the imagePullSecrets for every single RunnerDeployment which could be repetitive and prune to errors

Additional context
N/A

@fgalind1 fgalind1 changed the title Support imagePullSecrets in runner pod for private docker registries Support default imagePullSecrets in runner pod for private docker registries Oct 15, 2021
@stale
Copy link

stale bot commented Nov 14, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Nov 14, 2021
@fgalind1
Copy link
Contributor Author

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

waiting for review of PR #921

@stale stale bot removed the stale label Nov 15, 2021
mumoshu added a commit that referenced this issue Dec 15, 2021
Resolves #896

Co-authored-by: Yusuke Kuoka <ykuoka@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant