You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem?.
When using a private docker registry it is required to provide the docker image as a imagePullSecrets in the runner pod spec. Runner pod spec supports imagePullSecrets, however it's quite useful to support this at the controller level with a default value similarly as it's done for runner image
Describe the solution you'd like
In the same way as a cmdline argument is supported to provide --runner-image, I'd like to have an option --runner-image-pull-secret-name or something similar that contains the secret name that holds the docker config and then use that to add the imagePullSecrets in the runner pod with something like:
Describe alternatives you've considered
Define the imagePullSecrets for every single RunnerDeployment which could be repetitive and prune to errors
Additional context
N/A
The text was updated successfully, but these errors were encountered:
fgalind1
changed the title
Support imagePullSecrets in runner pod for private docker registries
Support default imagePullSecrets in runner pod for private docker registries
Oct 15, 2021
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Is your feature request related to a problem?.
When using a private docker registry it is required to provide the docker image as a
imagePullSecrets
in the runner pod spec. Runner pod spec supports imagePullSecrets, however it's quite useful to support this at the controller level with a default value similarly as it's done for runner imageDescribe the solution you'd like
In the same way as a cmdline argument is supported to provide
--runner-image
, I'd like to have an option--runner-image-pull-secret-name
or something similar that contains the secret name that holds the docker config and then use that to add theimagePullSecrets
in the runner pod with something like:Describe alternatives you've considered
Define the imagePullSecrets for every single RunnerDeployment which could be repetitive and prune to errors
Additional context
N/A
The text was updated successfully, but these errors were encountered: