Add support for default image pull secret name #921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently it's supported to define imagePullSecrets in the runner spec e.g as a RunnerDeployment. However the controller can specify a default runner image. If this image is on a private registry it requires the image pull secret. This PR adds this option also to the controller to be consistent with supporting a default runner image. This makes it much easier when using runner images from private registries
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
still needed |
mumoshu
reviewed
Nov 29, 2021
|
@fgalind1 Sorry for the delay and thanks for your contribution! I'm going to review/merge this towards our next feature release(0.21.0) |
mumoshu
reviewed
Dec 12, 2021
mumoshu
reviewed
Dec 12, 2021
mumoshu
reviewed
Dec 12, 2021
fgalind1
force-pushed
the
support-default-image-pull-secrets
branch
from
944c8aa
to
7590eed
Compare
mumoshu
reviewed
Dec 14, 2021
mumoshu
reviewed
Dec 14, 2021
controllers/runner_controller.go
Outdated
Comment on lines
879
to
881
| pod.Spec.ImagePullSecrets = []corev1.LocalObjectReference{ | ||
| {Name: imagePullSecret}, | ||
| } |
There was a problem hiding this comment.
Suggested change
| pod.Spec.ImagePullSecrets = []corev1.LocalObjectReference{ | |
| {Name: imagePullSecret}, | |
| } | |
| pod.Spec.ImagePullSecrets = append(pod.Spec.ImagePullSecrets, []corev1.LocalObjectReference{ | |
| {Name: imagePullSecret}, | |
| }) |
otherwise pod.spec.ImagePullSecrets always contain one element which correlate to the last element in defualtRUnnerImagePullSecrets, which won't be what you want :)
There was a problem hiding this comment.
Thanks good catch - fixed in ffa0d58
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently it's supported to define
ImagePullSecretsin the runner spec e.g as aRunnerDeployment. However the controller can specify a default runner image.If this image is on a private registry it requires the image pull secret. This PR adds this option also to the controller to be consistent with supporting a default runner image. This makes it much
easier when using runner images from private registries
Fixes #896