Bump chart version to fix outdated CRDs #1021
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some CRD changes happened since the last chart version bump to pull the latest CRDs into the chart repo's tgz archive. Also take the latest appVersion.
|
@gtaylor Hey! Thank you for your contribution. Yes, #912 added dockerEnv to the runner spec but we have no controller release (v0.21.0) for that feature yet. My general recommendation is- if you're trying an unreleased version of the controller, use the chart from our main branch, not from the chart repo. Does that make sense? Or should I just take this as a warm request to release the new controller 0.21.0 along with the new chart version earlier? 😃 |
|
Whoops, that makes sense. Shall I close this PR? |
|
@gtaylor if you could, cheers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes happened to the CRDs since the last time that the Helm chart was bumped, so there are Helm users out there (like myself) who are running recent controllers with old CRDs. I am for example missing the new
dockerEnvfeature in the runnerdeployment resource.I have bumped the chart version to pull the latest CRDs into a new point release. I've also nudged the appVersion up to match the latest release.
It'll be important to bump the chart version any time a change is made that results in different YAML rendering behavior to avoid future recurrence of the breakage.