Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dockerEnv variable for RunnerDeployment #912

Merged
merged 5 commits into from Dec 14, 2021

Conversation

pavelsmolensky
Copy link
Contributor

@mumoshu mumoshu added this to the v0.21.0 milestone Nov 9, 2021
@stale
Copy link

stale bot commented Dec 9, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Dec 9, 2021
@toast-gear toast-gear removed the stale label Dec 9, 2021
Copy link
Collaborator

@toast-gear toast-gear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sledigabel
Copy link
Contributor

Perhaps updating the README would be useful?

@pavelsmolensky
Copy link
Contributor Author

@sledigabel done. Force pushed an update

README.md Show resolved Hide resolved
@mumoshu
Copy link
Collaborator

mumoshu commented Dec 14, 2021

Rebased and re-generated manifests to fix the build error

@mumoshu
Copy link
Collaborator

mumoshu commented Dec 14, 2021

Had to run make generate manifests to update manifests and code 😄 Merging. Thank you for your contribution @pavelsmolensky and reviews @sledigabel @toast-gear!

@mumoshu mumoshu merged commit 91102c8 into actions:master Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants