Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(runner/entrypoint): check for externalstmp #1277

Merged
merged 2 commits into from
Mar 30, 2022

Conversation

lovesegfault
Copy link
Contributor

This fixes these annoying messages in the runner logs:

# Authentication
√ Connected to GitHub
# Runner Registration
√ Runner successfully added
√ Runner connection is good
# Runner settings
√ Settings Saved.
Runner successfully configured.
{
  "agentId": 123,
  "agentName": "runner-deployment-123",
  "poolId": 1,
  "poolName": "Default",
  "ephemeral": true,
  "serverUrl": "https://pipelines.actions.githubusercontent.com/123",
  "gitHubUrl": "https://github.com/123",
  "workFolder": "/runner/_work"
mkdir: cannot create directory './externals': File exists
mv: cannot stat './externalstmp/*': No such file or directory
}
√ Connected to GitHub

Current runner version: '2.289.1'
2022-03-27 11:04:41Z: Listening for Jobs

Emphasis:

mkdir: cannot create directory './externals': File exists
mv: cannot stat './externalstmp/*': No such file or directory

@toast-gear
Copy link
Collaborator

LGTM, cheers. I've removed the directory check as it shouldn't be needed and I'm hesitant changing the move logic in case it impacts some edge case

@toast-gear toast-gear merged commit e46df41 into actions:master Mar 30, 2022
@lovesegfault lovesegfault deleted the fix-externals branch April 6, 2022 21:32
billimek added a commit to homedepot/actions-runner-controller that referenced this pull request Apr 12, 2022
* master: (30 commits)
  chore(deps): update azure/setup-helm action to v2.1 (actions#1328) [skip ci]
  Add more usages of RUNNER_VERSION to Renovate config. (actions#1313)
  chore: fix typo (actions#1316) [skip ci]
  chore: bump chart to latest (actions#1319)
  Fix release workflow
  Prevent runners from stuck in Terminating when pod disappeared without standard termination process (actions#1318)
  ci: pin go version to the known working version (actions#1303)
  chore: bump chart to latest (actions#1300)
  Fix runner pod to be cleaned up earlier regardless of the sync period (actions#1299)
  Make the hard-coded runner startup timeout to avoid race on token expiration longer (actions#1296)
  docs: highlight why persistent are not ideal
  fix(deps): update module sigs.k8s.io/controller-runtime to v0.11.2
  chore(deps): update dependency actions/runner to v2.289.2
  chore(deps): update helm/chart-releaser-action action to v1.4.0 (actions#1287)
  refactor(runner/entrypoint): check for externalstmp (actions#1277)
  docs: redundant words
  docs: wording
  docs: add autoscaling also causes problems
  chore: new line for consistency
  docs: use the right font
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants