Fix runner pod to be cleaned up earlier regardless of the sync period #1299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 6, 2022
Closed
billimek
added a commit
to homedepot/actions-runner-controller
that referenced
this pull request
Apr 12, 2022
* master: (30 commits) chore(deps): update azure/setup-helm action to v2.1 (actions#1328) [skip ci] Add more usages of RUNNER_VERSION to Renovate config. (actions#1313) chore: fix typo (actions#1316) [skip ci] chore: bump chart to latest (actions#1319) Fix release workflow Prevent runners from stuck in Terminating when pod disappeared without standard termination process (actions#1318) ci: pin go version to the known working version (actions#1303) chore: bump chart to latest (actions#1300) Fix runner pod to be cleaned up earlier regardless of the sync period (actions#1299) Make the hard-coded runner startup timeout to avoid race on token expiration longer (actions#1296) docs: highlight why persistent are not ideal fix(deps): update module sigs.k8s.io/controller-runtime to v0.11.2 chore(deps): update dependency actions/runner to v2.289.2 chore(deps): update helm/chart-releaser-action action to v1.4.0 (actions#1287) refactor(runner/entrypoint): check for externalstmp (actions#1277) docs: redundant words docs: wording docs: add autoscaling also causes problems chore: new line for consistency docs: use the right font ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is intended to be the minimum addition to the runner status to help the runner replicaset controller to notice that the runner pod is NotReady(due to whatever reasons like the runner container that is running an ephemeral runner completely successfully).
The runner replicaset controller is already able to terminate a NotReady runner and create a new runner as a replacement (if needed). That behavior, in combination with this fix, seems to fix the issue reported in #1291 for me.
Ref #1291