Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Force restartPolicy "Never" to prevent runner pods from stucking in Terminating when the container disappeared #1395

Merged
merged 1 commit into from
May 14, 2022
Merged

Force restartPolicy "Never" to prevent runner pods from stucking in Terminating when the container disappeared #1395

merged 1 commit into from
May 14, 2022

Conversation

mumoshu
Copy link
Collaborator

@mumoshu mumoshu commented Apr 28, 2022 •
edited

Note that there might be the same issue in runner pods managed by RunnerSet, but the fix for that isn't trivial.
That's why this PR contains the fix for RunnerDeployment only. It turned out we are able to mutate pod specs in the mutating webhook so it's alright. This should work for both RunnerDeployment and RunnerSet.

Ref #1369

@lovesegfault lovesegfault mentioned this pull request Apr 28, 2022
Merged
@mumoshu mumoshu mentioned this pull request Apr 29, 2022
Closed
@toast-gear toast-gear added this to the v0.24.0 milestone May 4, 2022
mumoshu added a commit that referenced this pull request May 9, 2022
@mumoshu
Fix runner pods managed by RunnerSet to not stuck in Terminating
225a34d 
This is intended to fix #1369 mostly for RunnerSet-managed runner pods. It is "mostly" because this fix might work well for RunnerDeployment in cases that #1395 does not work, like in a case that the user explicitly set the runner pod restart policy to anything other than "Never".

Ref #1369
@mumoshu mumoshu mentioned this pull request May 9, 2022
Merged
toast-gear pushed a commit that referenced this pull request May 12, 2022
@mumoshu
fix: runner pods managed by RunnerSet to not stuck in Terminating (#1420
e46b90f 
)

This is intended to fix #1369 mostly for RunnerSet-managed runner pods. It is "mostly" because this fix might work well for RunnerDeployment in cases that #1395 does not work, like in a case that the user explicitly set the runner pod restart policy to anything other than "Never".

Ref #1369
@mumoshu mumoshu force-pushed the fix-runner-pod-stuck-in-terminating-after-container-disappeared branch from 966b811 to 32b0fe4 Compare May 12, 2022 23:10
@mumoshu mumoshu changed the title Fix runner pods created by RunnerDeployment stuck in Terminating when the runner container disappeared Force restartPolicy "Never" to prevent runner pods from stucking in Terminating when the container disappeared May 12, 2022
@mumoshu mumoshu force-pushed the fix-runner-pod-stuck-in-terminating-after-container-disappeared branch from 32b0fe4 to c36e99a Compare May 12, 2022 23:14
@mumoshu mumoshu force-pushed the fix-runner-pod-stuck-in-terminating-after-container-disappeared branch from c36e99a to 988389a Compare May 12, 2022 23:20
@toast-gear toast-gear merged commit 759349d into master May 14, 2022
@toast-gear toast-gear deleted the fix-runner-pod-stuck-in-terminating-after-container-disappeared branch May 14, 2022 08:07
@mumoshu mumoshu mentioned this pull request Jun 15, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toast-gear toast-gear toast-gear approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.24.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mumoshu @toast-gear