Fix self-update failuers due to /runner/externals mount

[mumoshu]

Please follow the steps described in https://github.com/summerwind/actions-runner-controller#developing to build the container images for testing.

Fixes #252

[jolestar]

unable to find user runner/runner: no matching entries in passwd file, this is correct?

[mumoshu]

Sorry this should just be USER runner

[jolestar]

I try use new runner image, got:

Github endpoint URL https://github.com/
mv: cannot move '/runnertmp/bin' to '/runner/bin': Permission denied
mv: cannot move '/runnertmp/config.sh' to '/runner/config.sh': Permission denied
mv: cannot move '/runnertmp/env.sh' to '/runner/env.sh': Permission denied
mv: cannot move '/runnertmp/externalstmp' to '/runner/externalstmp': Permission denied
mv: cannot move '/runnertmp/patched' to '/runner/patched': Permission denied
mv: cannot move '/runnertmp/run.sh' to '/runner/run.sh': Permission denied
/entrypoint.sh: line 56: ./config.sh: No such file or directory
mv: cannot stat './externalstmp/*': No such file or directory
diff: bin/runsvc.sh: No such file or directory
diff: patched/runsvc.sh: No such file or directory
mv: cannot stat 'bin/runsvc.sh': No such file or directory
mv: cannot stat 'patched/runsvc.sh': No such file or directory
diff: bin/RunnerService.js: No such file or directory
diff: patched/RunnerService.js: No such file or directory
mv: cannot stat 'bin/RunnerService.js': No such file or directory
mv: cannot stat 'patched/RunnerService.js': No such file or directory
/entrypoint.sh: line 68: /runner/bin/runsvc.sh: No such file or directory

[mumoshu]

@jolestar Thanks. Ah - Probably you need sudo chown -R runner:docker /runner in the very beginning of your entrypoint.sh

https://github.com/summerwind/actions-runner-controller/blob/master/runner/entrypoint.sh

As we use that user and group in our dockerfile

https://github.com/summerwind/actions-runner-controller/blob/524cf1b3793aeb8ea6280b2c1cd0a9cd55090173/runner/Dockerfile#L53-L55

[jolestar]

@mumoshu

Need add "mkdir ./externals" at here

https://github.com/summerwind/actions-runner-controller/blob/524cf1b3793aeb8ea6280b2c1cd0a9cd55090173/runner/entrypoint.sh#L51

the runnertmp dir also need to chown -R runner:docker.

It is work for me now.

[mumoshu]

Need add "mkdir ./externals" at here

Ahhh, good catch! That makes sense. Thanks a lot for sharing your insight 👍

[jolestar]

HorizontalRunnerAutoscaler can not get correct DESIRED value, I'm trying to figure out why. May be it is github action api's bug, too many action job is timeout, and all job's status is weird

[mumoshu]

Let's go ahead! Thanks for all your help @e36-cicd, @jolestar, @achedeuzot, @hfuss, and everyone involved ❤️