Tested Self-update Fixes #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One of the pod recreation conditions has been modified to use hash of runner spec, so that the controller does not keep restarting pods mutated by admission webhooks. This naturally allows us, for example, to use IRSA for EKS that requires its admission webhook to mutate the runner pod to have additional, IRSA-related volumes, volume mounts and env. Resolves actions#200
Co-authored-by: Callum Tait <callum.tait@PBXUK-HH-05772.photobox.priv>
Co-authored-by: Callum Tait <callum.tait@PBXUK-HH-05772.photobox.priv>
…ctions#223) * hpa scheme based off busy runners * running make manifests Co-authored-by: Zachary Benamram <zacharybenamram@blend.com>
…ound up (actions#235) * remove magic number for autoscaling Co-authored-by: Zachary Benamram <zacharybenamram@blend.com>
* adding readme for new hpa scheme * callum's comments Co-authored-by: Zachary Benamram <zacharybenamram@blend.com>
…ns-runner-controller into testing-self-update-fix-2.276.0
mumoshu
approved these changes
Jan 24, 2021
There was a problem hiding this comment.
LGTM. Thanks for completing my fix @hfuss and @achedeuzot!!
mumoshu
added a commit
that referenced
this pull request
Jan 24, 2021
* Fix self-update failuers due to /runner/externals mount Fixes #252 * Tested Self-update Fixes (#269) Adding fixes to #253 as confirmed and tested in #264 (comment) by @jolestar, @achedeuzot and @hfuss 🙇 🍻 Co-authored-by: Hayden Fuss <wifu1234@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Courtesy of @achedeuzot
Tested on OpenShift 3.11.