-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crds custom annotations #3472
base: master
Are you sure you want to change the base?
Crds custom annotations #3472
Conversation
@mumoshu @toast-gear @rentziass @nikola-jokic |
Hi @GSZoominfo , |
You don't want to do this as setting it on Application level might break other functionalities like sync waves/hooks. The approach chosen in this PR is a good one. We see similar implementations on prometheus, kyverno, argocd:
|
This PR will allow us to add custom annotations to the crds
use case:
argocd.argoproj.io/sync-options: ServerSideApply=true