Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for default image pull secret name #921

Merged
merged 7 commits into from
Dec 15, 2021
Merged

Add support for default image pull secret name #921

merged 7 commits into from
Dec 15, 2021

Commits on Oct 28, 2021

  1. Add support for default image pull secret name 

    Currently it's supported to define imagePullSecrets in the runner spec
e.g as a RunnerDeployment. However the controller can specify a default
runner image.

If this image is on a private registry it requires the
image pull secret. This PR adds this option also to the controller to be
consistent with supporting a default runner image. This makes it much
easier when using runner images from private registries
    @fgalind1
    fgalind1 committed Oct 28, 2021
    Configuration menu
    Copy the full SHA
    f1ac3c8 View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2021

  1. Set default runner image pull secret only if it's not already set

    @fgalind1
    fgalind1 committed Nov 29, 2021
    Configuration menu
    Copy the full SHA
    f08d2f3 View commit details
    Browse the repository at this point in the history

Commits on Dec 12, 2021

  1. Add command-line flag for the default runner image pull secret config

    @mumoshu
    mumoshu committed Dec 12, 2021
    Configuration menu
    Copy the full SHA
    1f6facb View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2021

  1. Update usage of image pull secret in helm chart as generic secrets

    @fgalind1
    fgalind1 committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    2d62544 View commit details
    Browse the repository at this point in the history

  2. Consolidate usage of actionsRunnerImagePullSecretName

    @fgalind1
    fgalind1 committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    7590eed View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2021

  1. Remove extra secrets and support multiple image pull secret values in… 

    … cmdline
    @fgalind1
    fgalind1 committed Dec 14, 2021
    Configuration menu
    Copy the full SHA
    fd881f7 View commit details
    Browse the repository at this point in the history

  2. Fix adding image pull secrets into pod spec

    @fgalind1
    fgalind1 committed Dec 14, 2021
    Configuration menu
    Copy the full SHA
    ffa0d58 View commit details
    Browse the repository at this point in the history