Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update go-github from v37 -> v39 #925

Merged
merged 1 commit into from Dec 11, 2021

Conversation

pje
Copy link
Member

@pje pje commented Oct 29, 2021

Like #800, but also update imports to use the new version :)

I ran:

go get -u github.com/google/go-github/v39
rg --files-with-matches 'github.com/google/go-github/v37/github' **/*.go | xargs sed -i '' "s|github.com/google/go-github/v37/github|github.com/google/go-github/v39/github|g"
go mod tidy

In particular this pulls in the changes @mumoshu made in google/go-github#2103 that have since been merged into their main, so we no longer need the replace directive in go.mod.

@pje
Copy link
Member Author

pje commented Nov 10, 2021

Can I help move this along in any way? Is there manual testing that needs to be done? Thanks!

@mumoshu mumoshu added this to the v0.21.0 milestone Nov 10, 2021
@mumoshu
Copy link
Collaborator

mumoshu commented Nov 10, 2021

@pje Sorry for the delay! I'm sure this will be a part of our next feature release (v0.21.0)

@pje
Copy link
Member Author

pje commented Nov 16, 2021

@mumoshu no worries! Just wanted to know if I could help test or something. 👍

@mumoshu mumoshu force-pushed the users/pje/update-go-github-to-v39 branch from b26f816 to 82b2962 Compare December 11, 2021 12:38
@mumoshu
Copy link
Collaborator

mumoshu commented Dec 11, 2021

Thanks for your patience! Fixed conflicts and force-pushed to your branch. I'm now waiting for the build to pass 😄

@mumoshu
Copy link
Collaborator

mumoshu commented Dec 11, 2021

All green! Merging. Thanks a lot for your support @pje ☺️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants