fix: pagination for ListWorkflowJobs in autoscaler (#990) #992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mumoshu
force-pushed
the
autoscaling-workflowjobs-pagination
branch
from
3dcf52b
to
180e645
Compare
|
@larhauga Thanks for your contribution! Rebased and I'm now trying to test this locally. If you could help double-checking, it would be great if you could follow our contribution guide for local testing. |
mumoshu
reviewed
Dec 14, 2021
controllers/autoscaling.go
Outdated
| @@ -10,6 +10,7 @@ import ( | |||
| "time" | |||
|
|
|||
| "github.com/actions-runner-controller/actions-runner-controller/api/v1alpha1" | |||
| "github.com/google/go-github/v37/github" | |||
There was a problem hiding this comment.
Suggested change
| "github.com/google/go-github/v37/github" | |
| "github.com/google/go-github/v39/github" |
This seems outdated since #925. I'll update your commit with the change.
mumoshu
force-pushed
the
autoscaling-workflowjobs-pagination
branch
from
180e645
to
e3c3c39
Compare
|
Sry it took much longer time than I had thought to have time to test this manually! Code LGTM so let merge this anyway and make follow-ups only after we find any issues layer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding handling of paginated results when calling
ListWorkflowJobs. By default theper_pageis 30, which potentially would return 30 queued and 30 in_progress jobs.This change should enable the autoscaler to scale workflows with more than 60 jobs to the exact number of runners needed.
Problem: I did not find any support for pagination in the Github fake client, and have not been able to test this (as I have not been able to push an image to an environment where I can verify this).
If anyone is able to help out verifying this PR, i would really appreciate it.
Ref #990