Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consume new @actions/github for GHES support #236

Merged
merged 1 commit into from May 7, 2020

Conversation

@ericsciple
Copy link
Collaborator

@ericsciple ericsciple commented May 7, 2020

Let the toolkit set the baseUrl (GHES vs Dotcom) when constructing the Octokit REST client

@@ -75,8 +74,8 @@ async function downloadArchive(
ref: string,
commit: string
): Promise<Buffer> {
const octokit = new github.GitHub(authToken, {baseUrl: urlHelper.getApiUrl()})
const params: ReposGetArchiveLinkParams = {
const octokit = new github.GitHub(authToken)
Copy link
Collaborator Author

@ericsciple ericsciple May 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let the toolkit set the baseUrl

@ericsciple ericsciple requested a review from thboop May 7, 2020
import {default as uuid} from 'uuid/v4'
import {ReposGetArchiveLinkParams} from '@octokit/rest'
import {Octokit} from '@octokit/rest'
Copy link
Collaborator Author

@ericsciple ericsciple May 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wasnt able to import directly anymore (compat break)

thboop
thboop approved these changes May 7, 2020
Copy link
Collaborator

@thboop thboop left a comment

LGTM

@ericsciple ericsciple merged commit ac45559 into master May 7, 2020
6 checks passed
@ericsciple ericsciple deleted the users/ericsciple/m261ghes branch May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants