Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update readme for v3 #708

Merged
merged 3 commits into from Mar 1, 2022
Merged

update readme for v3 #708

merged 3 commits into from Mar 1, 2022

Conversation

thboop
Copy link
Collaborator

@thboop thboop commented Mar 1, 2022

No description provided.

@thboop thboop requested a review from ericsciple Mar 1, 2022
@ericsciple
Copy link
Contributor

@ericsciple ericsciple commented Mar 1, 2022

Do we need a section to indicate whats new in v3?

@ericsciple
Copy link
Contributor

@ericsciple ericsciple commented Mar 1, 2022

Basically, what do users on v2 need to know?

@thboop thboop merged commit a12a394 into main Mar 1, 2022
10 checks passed
@thboop thboop deleted the thboop/updateReadmeForV3 branch Mar 1, 2022
@jglick jglick mentioned this pull request Mar 22, 2022
@eregon
Copy link

@eregon eregon commented Mar 31, 2022

I'd be useful to mention this node update is because of, quoting #689

Node 12 has an end of life on April 30, 2022.

I'm not sure why this should be a major release, it feels like a lot of churn for every workflow out there, most of them likely running on GH-hosted or recent-enough runners, and for which using a new 2.x release would have been better.

Does it mean - uses: actions/checkout@v2 which is used in so many workflows will no longer get updates/bug fixes?

This feels wrong, people using old runners should pin to a specific release or sha, people using reasonably recent runners should be able to get updates/bug fixes without needing to update all workflows with a new checkout major version every now and then (unless the semantics of the action does change and really needs a major release).


Refer [here](https://github.com/actions/checkout/blob/v1/README.md) for previous versions.
- Updated to the node16 runtime by default
- This requires a minimum [Actions Runner](https://github.com/actions/runner/releases/tag/v2.285.0) version of v2.285.0 to run, which is by default available in GHES 3.4 or later.
Copy link

@jglick jglick Mar 31, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be worth explicitly mentioning here (and, more importantly, in https://github.com/actions/checkout/releases/tag/v3.0.0) that if you are using github.com (SaaS) you can safely accept the update and ignore the rest of the text.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants