Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to node 16 #689

Merged
merged 4 commits into from Feb 28, 2022
Merged

Update to node 16 #689

merged 4 commits into from Feb 28, 2022

Conversation

thboop
Copy link
Collaborator

@thboop thboop commented Feb 7, 2022

Node 12 has an end of life on April 30, 2022.

This PR updates the default runtime to node16, rather then node12.

This is supported on all Actions Runners v2.285.0 or later.

@thboop thboop requested a review from ericsciple Feb 7, 2022
@@ -69,6 +69,6 @@ inputs:
converted to HTTPS.
default: false
runs:
using: node12
using: node16
Copy link
Collaborator

@ericsciple ericsciple Feb 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are we concerned about older GHES + GitHub Connect?

Copy link
Collaborator Author

@thboop thboop Feb 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will major version these changes, so users using GitHub Connect can stay pinned on @v2 so if they are on a very old GHES version their workflows will still run.

Copy link
Collaborator

@ericsciple ericsciple Feb 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also discussed offline. sounds like this is the same plan we're using across all in-the-box actions.

@@ -13,7 +13,7 @@ jobs:
steps:
- uses: actions/setup-node@v1
with:
node-version: 12.x
node-version: 16.x
Copy link
Collaborator

@ericsciple ericsciple Feb 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are there any cases where we will fallback to node12? Wondering whether worth having a test matrix

Copy link
Collaborator Author

@thboop thboop Feb 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not at this moment, the version defined in the action.yaml is the version we use. Once we release a new major version, I can update this and the readme to include more testing (we can cut a releases/v2 branch to mirror our v1 branch) and test both that and the main branch

@jglick
Copy link

jglick commented Mar 2, 2022

Please consider adding some note to https://github.com/actions/checkout/releases/tag/v3.0.0 explaining what practical impact this might have on users that would justify the major version bump. actions/setup-java#290 (comment) has more discussion.

Copy link

@cabdiiidle11 cabdiiidle11 left a comment

2000

@SuperSandro2000
Copy link

SuperSandro2000 commented Mar 7, 2022

Please consider adding some note to v3.0.0 (release) explaining what practical impact this might have on users that would justify the major version bump. actions/setup-java#290 (comment) has more discussion.

Yes please. Otherwise this looks like a pointless major bump which triggers thousands of dependabot pull requests.

@jglick
Copy link

jglick commented Mar 22, 2022

(There is #708 but that is not displayed as part of Dependabot PRs.)

Copy link

@calbearox calbearox left a comment

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

@SuperSandro2000
Copy link

SuperSandro2000 commented Mar 31, 2022

Nice token you have there. I would recommend to revoke it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants