Update to node 16 #689
Update to node 16 #689
Conversation
update setup node version
| @@ -69,6 +69,6 @@ inputs: | |||
| converted to HTTPS. | |||
| default: false | |||
| runs: | |||
| using: node12 | |||
| using: node16 | |||
There was a problem hiding this comment.
are we concerned about older GHES + GitHub Connect?
There was a problem hiding this comment.
We will major version these changes, so users using GitHub Connect can stay pinned on @v2 so if they are on a very old GHES version their workflows will still run.
There was a problem hiding this comment.
also discussed offline. sounds like this is the same plan we're using across all in-the-box actions.
| @@ -13,7 +13,7 @@ jobs: | |||
| steps: | |||
| - uses: actions/setup-node@v1 | |||
| with: | |||
| node-version: 12.x | |||
| node-version: 16.x | |||
There was a problem hiding this comment.
are there any cases where we will fallback to node12? Wondering whether worth having a test matrix
There was a problem hiding this comment.
Not at this moment, the version defined in the action.yaml is the version we use. Once we release a new major version, I can update this and the readme to include more testing (we can cut a releases/v2 branch to mirror our v1 branch) and test both that and the main branch
|
Please consider adding some note to https://github.com/actions/checkout/releases/tag/v3.0.0 explaining what practical impact this might have on users that would justify the major version bump. actions/setup-java#290 (comment) has more discussion. |
Yes please. Otherwise this looks like a pointless major bump which triggers thousands of dependabot pull requests. |
|
(There is #708 but that is not displayed as part of Dependabot PRs.) |
|
Nice token you have there. I would recommend to revoke it. |
Node 12 has an end of life on April 30, 2022.
This PR updates the default runtime to node16, rather then node12.
This is supported on all Actions Runners v2.285.0 or later.