Add WSL

[dsame]

Description

New tool

Installing Windows Subsystem for Linux is turning on Windows Optional feature. Installation time: 1sec

Related issue: #50

Check list

• Related issue / work item is attached
• Changes are tested and related VM images are successfully generated

[miketimofeev]

Let's add validation script as usual and add wsl to software report

[AlenaSviridenko]

I also think we should add a note to Readme about WSL

[AlenaSviridenko]

/azp run windows2019

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[AlenaSviridenko]

/azp run windows2019

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[AlenaSviridenko]

/azp run windows2019

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[Manishearth]

I think our Windows builds started failing because of this, see rust-lang/rust#73566 (comment)

[Manishearth]

We're fixing it by explicitly setting the shell: rust-lang/rust#74406

[The-Compiler]

FWIW if you have some kind of test which relies on bash working when it's available (and which gets skipped if not), this change likely will break it. In pytest, we moved to instead checking bash --version output: pytest-dev/pytest#7520

[al-cheb]

Hello, @The-Compiler.
After installing WSL feature we have got another place which contains bash.exe - C:\Windows\System32\bash.exe. On Windows, the subprocess class uses the Windows CreateProcess() function. If the file name does not contain a directory path, the system searches for the executable file in the following sequence:

1. The directory from which the application loaded.
2. The current directory for the parent process.
   3. The 32-bit Windows system directory. Use the GetSystemDirectory function to get the path of this directory.
3. The 16-bit Windows system directory. There is no function that obtains the path of this directory, but it is searched. The name of this directory is System.
4. The Windows directory. Use the GetWindowsDirectory function to get the path of this directory.
5. The directories that are listed in the PATH environment variable. Note that this function does not search the per-application path specified by the App Paths registry key. To include this per-application path in the search sequence, use the ShellExecute function.

If the file name does not contain an extension, .exe is appended, therefore bash is equivalent to bash.exe . Using logic above it first looks in the GetSystemDirectory = C:\Windows\System32 directory , before than in the PATH environment variable.

In that case you should use follow approaches:

1. Add the parameter shell=True - https://bugs.python.org/issue8557, https://stackoverflow.com/questions/24789749/popen-with-conflicting-executable-path
   subprocess.run(..., shell=True)

2. Set a fully qualified path to a bash shell application:
   subprocess.run(['C:\\Program Files\\Git\\bin\\bash.exe']....)

3. shutil. which() method tells the path to an executable application which would be run if the given cmd was called. This method can be used to find a file on computer which is present on the PATH.

4. Delete C:\Windows\System32\bash.exe (@H-M-H)

[umarcor]

@The-Compiler I found the same issue with GitHub Actions and pytest. The following would fail:

    def setUp(self):
        self.shell = ['bash'] if platform == 'win32' else []
        print('\n::group::Log')
        sys.stdout.flush()

    def tearDown(self):
        print('\n::endgroup::')
        sys.stdout.flush()

    def _sh(self, args):
        check_call(self.shell + args, stderr=STDOUT)

Instead of setting shell=True or hardcoding the full path, I could work around it using which from shutil:

    def setUp(self):
        self.shell = [which('bash')] if platform == 'win32' else []
        print('\n::group::Log')
        sys.stdout.flush()

This seems to look into the PATH, skipping the GetSystemDirectory function that @al-cheb commented.

[H-M-H]

Another alternative that makes CreateProcess work again is to just delete: C:\Windows\System32\bash.exe