-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
testing: use a tighter check if bash
is available
#7520
Conversation
This fixes CI on Windows since GitHub Actions started installing WSL on their images which apparently installs some wrapper `bash` which does not run actual bash.
The diff looks good, but I'm a bit confused about the CI output now:
that looks like those tests are actually passing now, rather than being skipped? 🤔 |
The skip in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I missed the second line mentioning the same file! Seems fine then, merging this. Thanks!
["bash", "--version"], | ||
stdout=subprocess.PIPE, | ||
stderr=subprocess.PIPE, | ||
universal_newlines=True, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
check=True here?
bash_version = subprocess.run( | ||
["bash", "--version"], | ||
stdout=subprocess.PIPE, | ||
stderr=subprocess.PIPE, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you only look at the .stdout, so I think it's cleaner with stderr=subprocess.DEVNULL
?
Sorry for the fast merge, I thought it'd be good to unblock the CI before more people start running into issues with their PRs. I'd be happy to review a follow-up PR (and also wait a bit before merging there) - agreed with |
No worries, I only got the email notification when the merge happened. |
Fixes #7518.
This fixes CI on Windows since GitHub Actions started installing WSL on their images which apparently installs some wrapper
bash
which does not run actual bash.