Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add boilerplate to support using kubernetes as container provider #1522

Closed
wants to merge 1 commit into from

Conversation

fgalind1
Copy link

@fgalind1 fgalind1 commented Dec 1, 2021

This defines the initial base layout to support additional container providers besides using docker such as kuberentes.

Feature is not yet enabled

@fgalind1 fgalind1 requested a review from a team as a code owner December 1, 2021 00:13
@fgalind1
Copy link
Author

fgalind1 commented Dec 1, 2021

@ethomson I've created this initial PR as discussed offline without the real implementation yet

@drewboswell
Copy link

This would solve so many of our headaches. +1

@ethomson
Copy link
Contributor

ethomson commented Feb 26, 2022

@drewboswell Yes! Mine, too. 😁

I regret that it's taken so long to make progress on this - I deeply appreciate the work that @fgalind1 has done here. I'm very pleased that we have started to look at this and evaluate it. To give some more insight into my priorities: running in Kubernetes is the top priority for the runner team as soon as we finish up the last of the work to move over the actions runtime from the soon-to-be-end-of-life Node 12 to Node 16. Unfortunately, this work was delayed because the newest versions of Node tickled a fun kernel bug with overlay filesystems - so unfortunately affecting most Kubernetes installs in cloud providers.

It's rare that you get to say "it's a kernel bug!" when you encounter a problem, but the joy of encountering that extremely rare occurrence is wiped out by the disappointment when you realize that now you have to get everybody to patch their kernels before your software works.

In any case - I apologize for the tangent. We're excited about this and taking a serious look at both improving how our runner works in Kubernetes and with Actions Runner Controller in general, and this PR in particular.

Thanks for your patience!

@fgalind1 fgalind1 closed this Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants