Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Golang 1.15 was released over one month ago #74

Closed
alessio opened this issue Sep 13, 2020 · 7 comments
Closed

Golang 1.15 was released over one month ago #74

alessio opened this issue Sep 13, 2020 · 7 comments
Labels
duplicate This issue or pull request already exists feature request New feature or request to improve the current logic

Comments

@alessio
Copy link

alessio commented Sep 13, 2020

Hi!

Go 1.15 was released on August 11th, yet we can't yet use it in our builds.

Please advise.

Thanks for considering.

(CC'ing @marbar3778)

tmthrgd added a commit to tmthrgd/miekgdns that referenced this issue Oct 14, 2020
This bumps Travis CI to the last two supported golang releases, as
documented in the readme: go1.14 and go1.15.

It also bumps the GitHub Code Action CI to go1.14 as it doesn't yet
supported go1.15 (see actions/setup-go#74).
miekg pushed a commit to miekg/dns that referenced this issue Oct 14, 2020
This bumps Travis CI to the last two supported golang releases, as
documented in the readme: go1.14 and go1.15.

It also bumps the GitHub Code Action CI to go1.14 as it doesn't yet
supported go1.15 (see actions/setup-go#74).
@lrstanley
Copy link

This is becoming a very annoying issue to have to work around. setup-go is constantly behind versions by quite a bit. When the Go team releases a new Go version that has fixes for various CVE's, it's critical to be able to pull that version and be able to release new versions/run new builds based off that new version.

The past 8 versions or so, I've been constantly behind, expecting to be able to run another build, and have it pull in an older version (sometimes more than one patch version behind!).

setup-go should really not require manual adjustments to get new versions. Maybe it's worth not reinventing the wheel, and utilizing something like https://github.com/travis-ci/gimme?

@circa10a
Copy link

circa10a commented Dec 4, 2020

Maybe support version: latest ?

@hazcod
Copy link

hazcod commented Dec 10, 2020

FYI I use a Docker image in .github/ which I update automatically with dependabot.

      -
        id: vars
        run: |
          echo ::set-output name=go_version::$(grep '^FROM go' .github/go/Dockerfile | cut -d ' ' -f 2 | cut -d ':' -f 2)
          echo "Using Go version ${{ steps.vars.outputs.go_version }}"
      -
        name: Setup go
        uses: actions/setup-go@v2
        with:
          go-version: ${{ steps.vars.outputs.go_version }}

@circa10a
Copy link

circa10a commented Dec 11, 2020

Alternatively to get the latest:

steps:
  - id: vars
    run: |
      echo ::set-output name=go_version::$(curl -s https://raw.githubusercontent.com/actions/go-versions/main/versions-manifest.json | grep -oE '"version": "[0-9]{1}.[0-9]{1,}(.[0-9]{1,})?"' | head -1 | cut -d':' -f2 | sed 's/ //g; s/"//g')
  - name: Install Go
    uses: actions/setup-go@v2
    with:
      go-version: ${{ steps.vars.outputs.go_version }}

@tianon
Copy link

tianon commented Dec 15, 2020

Maybe it's worth not reinventing the wheel, and utilizing something like https://github.com/travis-ci/gimme?

I can say that https://github.com/travis-ci/gimme isn't exactly well-maintained, but was designed such that it (ideally) doesn't have to be. 😅

(I helped create it initially, although I'm not involved much anymore.)

@lrstanley
Copy link

Looking at go-versions, seems it's manually updated via an action. Why not have have it update automatically (and only when needed)? Could it run once a day (or sooner)? go-versions doesn't have issues enabled, so can't ask there...

@Sergey-Murtazin Sergey-Murtazin added needs eyes feature request New feature or request to improve the current logic and removed needs eyes labels Oct 19, 2021
@Sergey-Murtazin
Copy link
Contributor

Hi, @alessio!
Thanks for your request!

We will consider whether to add check latest version functionality.

I close this issue because it's a duplicate of 73#
Feel free to contact us and/or reopen this issue if you have any questions

@Sergey-Murtazin Sergey-Murtazin added the duplicate This issue or pull request already exists label Dec 21, 2021
aanm pushed a commit to cilium/dns that referenced this issue Jul 29, 2022
This bumps Travis CI to the last two supported golang releases, as
documented in the readme: go1.14 and go1.15.

It also bumps the GitHub Code Action CI to go1.14 as it doesn't yet
supported go1.15 (see actions/setup-go#74).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists feature request New feature or request to improve the current logic
Projects
None yet
Development

No branches or pull requests

6 participants