Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace testutil.NewTestCaseDir() with Go1.15's T.TempDir() #7014

Merged
merged 20 commits into from
Sep 18, 2020

Conversation

alessio
Copy link
Contributor

@alessio alessio commented Aug 12, 2020

Override go's default version with go 1.15.


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@tac0turtle
Copy link
Member

I'd wait a week before making this change. go 1.15 came out yesterday so many toole have not been updated yet

@tac0turtle
Copy link
Member

this should be good to go, @alessio i updated to master

@tac0turtle
Copy link
Member

merp, go 1.15 is available but not being used. hmmmmmm

@codecov
Copy link

codecov bot commented Sep 18, 2020

Codecov Report

Merging #7014 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #7014      +/-   ##
==========================================
- Coverage   54.86%   54.86%   -0.01%     
==========================================
  Files         586      586              
  Lines       35961    35958       -3     
==========================================
- Hits        19731    19728       -3     
  Misses      14310    14310              
  Partials     1920     1920              

@alessio alessio marked this pull request as ready for review September 18, 2020 10:17
Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@alessio alessio merged commit 3e616a6 into master Sep 18, 2020
@alessio alessio deleted the alessio/go1.15 branch September 18, 2020 11:08
larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023
)

Override go's default version with go 1.15.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants