-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace testutil.NewTestCaseDir() with Go1.15's T.TempDir() #7014
Conversation
I'd wait a week before making this change. go 1.15 came out yesterday so many toole have not been updated yet |
this should be good to go, @alessio i updated to master |
merp, go 1.15 is available but not being used. hmmmmmm |
Codecov Report
@@ Coverage Diff @@
## master #7014 +/- ##
==========================================
- Coverage 54.86% 54.86% -0.01%
==========================================
Files 586 586
Lines 35961 35958 -3
==========================================
- Hits 19731 19728 -3
Misses 14310 14310
Partials 1920 1920 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
9a24e27
to
108e780
Compare
Override go's default version with go 1.15.
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerCodecov Report
in the comment section below once CI passes