Cache issue in pnpm 7

[ai]

Description:

If we are using pnpm 7 with cache: pnpm in actions/setup-node@v3 and avoid installing dependencies we will have error:

Error: Cache folder path is retrieved for pnpm but doesn't exist on disk: /home/runner/.local/share/pnpm/store/v3

Action version: 3

Platform:

• Ubuntu
• macOS
• Windows

Runner type:

• Hosted
• Self-hosted

Tools version:

pnpm 7.0.0

Repro steps:

jobs:
  repro:
    - name: Install pnpm
        uses: pnpm/action-setup@v2
        with:
          version: latest
      - name: Install Node.js
        uses: actions/setup-node@v3
        with:
          node-version: 18
          registry-url: "https://registry.npmjs.org"
          scope: caniuse-lite
          cache: pnpm

Example

Expected behavior:

No error

Actual behavior:

> Post Install Node.js
1s
Post job cleanup.
/home/runner/setup-pnpm/node_modules/.bin/pnpm store path
/home/runner/.local/share/pnpm/store/v3
Error: Cache folder path is retrieved for pnpm but doesn't exist on disk: /home/runner/.local/share/pnpm/store/v3

[dmitry-shibanov]

Hello @ai. Thank you for your report. It looks like the step with installation dependencies was skipped, that is why the error was thrown, because it was nothing to save.

[ai]

@dmitry-shibanov yes. I temporary enable pnpm install for every case.

But it doesn’t look like a proper solution for me.

[dmitry-shibanov]

The setup-node action does not cache node_modules. It caches global cache directory. Besides, you're using latest version for the pnpm action and I think it has started to use the latest 7th version of pnpm, that is why path to global dependencies path could change and the setup-node action can't use the previous cache.

[dmitry-shibanov]

Hello @ai, just a gentle ping.

[ai]

@dmitry-shibanov yes, I understand it. I just do not understand why we fail CI in this case and do not ignore the missed folder?

[dmitry-shibanov]

Hello @ai. Thank you for your response. It's an expected behaviour. For more information please refer to these issues:

• Cache Size: ~0 MB (22 B) #281
• Upgrade to v2.3/v2.4 results in post-setup failure #317

For now I'm going to close the issue.

[riderx]

@dmitry-shibanov we still have the issue in pnpm and i don't find any solution who work for pnpm in your 2 issues linked.
if you look there : https://github.com/Cap-go/capgo/actions/runs/3262889396/jobs/5360721055
You can see your actions use /home/runner/.local/share/pnpm/store/v3 and pnpm also.
So i don't understand why no cache

[dmitry-shibanov]

Hello @riderx. I took a look at the build. Could you please create a separate issue to describe it more ? It does not fail for setup-node steps. Besides, it does not use cache in other jobs because they run in parallel that is why cache is not saved. Moreover, dependency file can be changed in every job that is why the action resaves cache.

[riderx]

Thanks a lot @dmitry-shibanov !
i created the issue #597
i tried to explain it better, feel free to ask more if needed.
i totally understand parallel job don't use the same cache, but in my case a same job between run don't reuse cache, what i expect