-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cache issue in pnpm 7 #479
Comments
Hello @ai. Thank you for your report. It looks like the step with installation dependencies was skipped, that is why the error was thrown, because it was nothing to save. |
@dmitry-shibanov yes. I temporary enable But it doesn’t look like a proper solution for me. |
The setup-node action does not cache node_modules. It caches global cache directory. Besides, you're using latest version for the pnpm action and I think it has started to use the latest 7th version of pnpm, that is why path to global dependencies path could change and the setup-node action can't use the previous cache. |
Hello @ai, just a gentle ping. |
@dmitry-shibanov yes, I understand it. I just do not understand why we fail CI in this case and do not ignore the missed folder? |
Hello @ai. Thank you for your response. It's an expected behaviour. For more information please refer to these issues: For now I'm going to close the issue. |
@dmitry-shibanov we still have the issue in pnpm and i don't find any solution who work for pnpm in your 2 issues linked. |
Hello @riderx. I took a look at the build. Could you please create a separate issue to describe it more ? It does not fail for setup-node steps. Besides, it does not use cache in other jobs because they run in parallel that is why cache is not saved. Moreover, dependency file can be changed in every job that is why the action resaves cache. |
Thanks a lot @dmitry-shibanov ! |
Description:
If we are using
pnpm 7
withcache: pnpm
inactions/setup-node@v3
and avoid installing dependencies we will have error:Action version: 3
Platform:
Runner type:
Tools version:
pnpm 7.0.0
Repro steps:
Example
Expected behavior:
No error
Actual behavior:
The text was updated successfully, but these errors were encountered: