feat: add volta as node-version-file

[jef]

Description:

Unlike other version managers, Volta places its versioning within package.json. We will check for volta.node to see if there is an value and use engines.node as backup. This is an important distinction, as volta.node should supersede engines.node.

Check list:

• Mark if documentation changes are required.
• Mark if tests were added or updated to cover the changes.

[dmitry-shibanov]

Hello @jef. Thank you for your pull request. Could you please run the npm run format command ? Besides, do we need to declare package.json as possible input ?

[jef]

Besides, do we need to declare package.json as possible input

thanks @dmitry-shibanov. great question. i also wasn't sure about this. i'm not sure if other projects use package.json for storing node.js versions. if so, then perhaps this could be more extendable.

edit: updating now to be a little more extendable. thanks for the input!

[dmitry-shibanov]

Thank you for reply @jef. I think we can remove package.json from this pull request because we have pull requests with adding support for package.json engine.

[jef]

pull requests with adding support for package.json engine.

ah, yes. i see that in #485. in this case, i believe there need some logic update into include volta.

should i wait until #485 is merged and then i proceed with mine?

[vsafonkin]

Hi @jef, could you please update your branch from main and resolve conflicts?

[jef]

Sure thing. I'll be back from vacation next week.

[jef]

Should be all good now @vsafonkin. Thanks!

[jef]

I've realized that the documentation for package.json is missing. Should I add it in here?

[dmitry-shibanov]

Hello @jef. Thank you for your suggestion. We would appreciate if you add this to the documentation, but if you want, we will do it on our side. Thank you!

[jef]

Alright, I've added in the documentation! Everything seems good from my end. Let me know if you need anything extra.

[vsafonkin]

Hi @jef, you need to resolve conflicts according #553 Thank you in advance!

[jef]

Hi @jef, you need to resolve conflicts according #553 Thank you in advance!

Not a problem! Should be all sorted. I also removed the try/catch on the latter half of parseNodeVersionFile only because it was throwing an error locally. Seemed better this way. I can revert if necessary.

Thanks!

[jef]

@vsafonkin, anything else you need before getting this in? Thanks!

[dmitry-shibanov]

Hello @jef. Sorry for the late response. Could you please e2e tests for volta ?

[e-korolevskii]

Hi @jef!

Just a gentle ping - we would like to know if you are planning to implement e2e tests here.

Thank you in advance!

[jef]

Sorry about that. Yes, I can implement some e2e tests. Is that going to be outside of the __tests__/installer.test.ts file?

[e-korolevskii]

Hello @jef!

Thanks for the quick response!
According to our contributor's guide, end-to-end tests are in the workflows folder, particularly in the versions.yml file.

[jef]

Hi @e-korolevskii, I believe I implemented something that should work for our needs. I can also combine it with the previous step if that makes more sense.

Thanks!

[e-korolevskii]

Hi @jef!

Now it looks good and I think we are ready to merge it.
I just wanted to thank you again for your contribution!

[jef]

Thanks for walking me through @e-korolevskii 😊