Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stale-issue/pr-message is required even if skip-stale-issue/pr-message is set to true #405

Closed
neverendingqs opened this issue Mar 27, 2021 · 3 comments · Fixed by #457
Closed

Comments

@neverendingqs
Copy link

neverendingqs commented Mar 27, 2021

stale-issue-message / stale-pr-message should probably not be required if skip-stale-issue-message / skip-stale-pr-message is set to true, since that string never gets used.

Workaround: set skip-stale-issue-message / skip-stale-pr-message to a non-empty string.

I think this happens because the check for a commit message (

const shouldMarkAsStale: boolean = shouldMarkWhenStale(daysBeforeStale);
if (!staleMessage && shouldMarkAsStale) {
issueLogger.info(`Skipping $$type due to empty stale message`);
continue;
}
) comes before we check if an issue is stale (
if (!issue.isStale && shouldBeStale && shouldMarkAsStale) {
issueLogger.info(
`Marking $$type stale because it was last updated on ${issue.updated_at} and it does not have a stale label`
);
await this._markStale(issue, staleMessage, staleLabel, skipMessage);
).

Example workflow: https://github.com/neverendingqs/serverless-dotenv-plugin/blob/8c02adbc653a90d681d5ededbb40300677cb8eac/.github/workflows/issues-cron.yml

Example run: https://github.com/neverendingqs/serverless-dotenv-plugin/runs/2209947040?check_suite_focus=true#step:2:35

@neverendingqs neverendingqs changed the title stale-issue/pr-message required even if skip-stale-issue/pr-message is set stale-issue/pr-message is required even if skip-stale-issue/pr-message is set Mar 27, 2021
@neverendingqs neverendingqs changed the title stale-issue/pr-message is required even if skip-stale-issue/pr-message is set stale-issue/pr-message is required even if skip-stale-issue/pr-message is set to true Mar 27, 2021
@github-actions
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

@github-actions github-actions bot added the Stale label Apr 27, 2021
@C0ZEN
Copy link
Contributor

C0ZEN commented Apr 27, 2021

up

@github-actions github-actions bot removed the Stale label Apr 28, 2021
@C0ZEN
Copy link
Contributor

C0ZEN commented May 23, 2021

Related to #455

C0ZEN added a commit to C0ZEN/stale that referenced this issue May 23, 2021
Closes actions#405
Closes actions#455

BREAKING CHANGES: remove skip-stale-issue-message and skip-stale-pr-message options. If you used this option, replace it by an empty message for the options stale-issue-message and stale-pr-message
C0ZEN added a commit to C0ZEN/stale that referenced this issue May 25, 2021
Closes actions#405
Closes actions#455

BREAKING CHANGES: remove skip-stale-issue-message and skip-stale-pr-message options. If you used this option, replace it by an empty message for the options stale-issue-message and stale-pr-message
luketomlinson pushed a commit that referenced this issue May 25, 2021
…#457)

* feat(options): simplify config by removing skip stale message options

Closes #405
Closes #455

BREAKING CHANGES: remove skip-stale-issue-message and skip-stale-pr-message options. If you used this option, replace it by an empty message for the options stale-issue-message and stale-pr-message

* build(dist): update dist

also lint some files

* docs(readme): update the docs by removing the skip options
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants