Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Node to v20 #1110

Merged
merged 10 commits into from
Dec 7, 2023
Merged

Conversation

aparnajyothi-y
Copy link
Contributor

@aparnajyothi-y aparnajyothi-y commented Nov 24, 2023

Description:
Code changes for Node version upgrade to 20

Related issue:
Feature request

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

@aparnajyothi-y aparnajyothi-y requested a review from a team as a code owner November 24, 2023 13:42
@aparnajyothi-y
Copy link
Contributor Author

Please review this PR. Thank you.

package.json Outdated
@@ -1,6 +1,6 @@
{
"name": "stale-action",
"version": "7.0.0",
"version": "8.0.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"version": "8.0.0",
"version": "9.0.0",

Comment on lines 36 to 42

type state_reason_type =
| 'completed'
| 'reopened'
| 'not_planned'
| null
| undefined;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was the reason for adding this type?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I was running npm run test few test and test suites are failed for the code
state_reason: this.options.closeIssueReason || undefined for that I have intialized status_reason and updated the line of code. Now I have rechecked the code and updated the line. All tests passed with same line now.

@@ -934,7 +941,7 @@ export class IssuesProcessor {
repo: context.repo.repo,
issue_number: issue.number,
state: 'closed',
state_reason: this.options.closeIssueReason || undefined
state_reason: this.options.closeIssueReason as state_reason_type
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this code update, you changed the logic. The this.options.closeIssueReason is typed as a string. The code state_reason: this.options.closeIssueReason || undefined means that if the this.options.closeIssueReason is an empty string we assign state_reason with undefined.
In your version of code this logic is changed. If the this.options.closeIssueReason is an empty string you assign state_reason with an empty string. What is the reason for that?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To resolve the failed tests for that particular line I have added the change and I missed the logic that I am assigning the empty string. Now I have updated the logic. Thank you for the clarification.

@aparnajyothi-y aparnajyothi-y merged commit 28ca103 into actions:main Dec 7, 2023
8 checks passed
julioc-lopez pushed a commit to julioc-lopez/zk that referenced this pull request Dec 8, 2023
Bumps actions/stale from 8 to 9.

Release notes
Sourced from actions/stale's releases.

v9.0.0
Breaking Changes
Action is now stateful: If the action ends because of operations-per-run then the next run will start from the first unprocessed issue skipping the issues processed during the previous run(s). The state is reset when all the issues are processed. This should be considered for scheduling workflow runs.
Version 9 of this action updated the runtime to Node.js 20. All scripts are now run with Node.js 20 instead of Node.js 16 and are affected by any breaking changes between Node.js 16 and 20.
What Else Changed
Performance optimization that removes unnecessary API calls by @​dsame #1033 fixes #792
Logs displaying current github API rate limit by @​dsame #1032 addresses #1029
For more information, please read the action documentation and its section about statefulness

New Contributors
@​jmeridth made their first contribution in actions/stale#984
@​nikolai-laevskii made their first contribution in actions/stale#1020
@​dusan-trickovic made their first contribution in actions/stale#1056
@​aparnajyothi-y made their first contribution in actions/stale#1110
Full Changelog: actions/stale@v8...v9.0.0
julioc-lopez pushed a commit to julioc-lopez/zk that referenced this pull request Dec 8, 2023
Bumps actions/stale from 8 to 9.

Release notes
Sourced from actions/stale's releases.

v9.0.0
Breaking Changes
Action is now stateful: If the action ends because of operations-per-run then the next run will start from the first unprocessed issue skipping the issues processed during the previous run(s). The state is reset when all the issues are processed. This should be considered for scheduling workflow runs.
Version 9 of this action updated the runtime to Node.js 20. All scripts are now run with Node.js 20 instead of Node.js 16 and are affected by any breaking changes between Node.js 16 and 20.
What Else Changed
Performance optimization that removes unnecessary API calls by @​dsame #1033 fixes #792
Logs displaying current github API rate limit by @​dsame #1032 addresses #1029
For more information, please read the action documentation and its section about statefulness

New Contributors
@​jmeridth made their first contribution in actions/stale#984
@​nikolai-laevskii made their first contribution in actions/stale#1020
@​dusan-trickovic made their first contribution in actions/stale#1056
@​aparnajyothi-y made their first contribution in actions/stale#1110
Full Changelog: actions/stale@v8...v9.0.0
julioc-lopez pushed a commit to julioc-lopez/zk that referenced this pull request Dec 8, 2023
Bumps actions/stale from 8 to 9.

Release notes
Sourced from actions/stale's releases.

v9.0.0
Breaking Changes
Action is now stateful: If the action ends because of operations-per-run then the next run will start from the first unprocessed issue skipping the issues processed during the previous run(s). The state is reset when all the issues are processed. This should be considered for scheduling workflow runs.
Version 9 of this action updated the runtime to Node.js 20. All scripts are now run with Node.js 20 instead of Node.js 16 and are affected by any breaking changes between Node.js 16 and 20.
What Else Changed
Performance optimization that removes unnecessary API calls by @​dsame #1033 fixes #792
Logs displaying current github API rate limit by @​dsame #1032 addresses #1029
For more information, please read the action documentation and its section about statefulness

New Contributors
@​jmeridth made their first contribution in actions/stale#984
@​nikolai-laevskii made their first contribution in actions/stale#1020
@​dusan-trickovic made their first contribution in actions/stale#1056
@​aparnajyothi-y made their first contribution in actions/stale#1110
Full Changelog: actions/stale@v8...v9.0.0
kayman-mk pushed a commit to Hapag-Lloyd/Renovate-Global-Configuration that referenced this pull request Dec 9, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [actions/stale](https://togithub.com/actions/stale) | action | major |
`v8.0.0` -> `v9.0.0` |

---

### Release Notes

<details>
<summary>actions/stale (actions/stale)</summary>

### [`v9.0.0`](https://togithub.com/actions/stale/releases/tag/v9.0.0)

[Compare
Source](https://togithub.com/actions/stale/compare/v8.0.0...v9.0.0)

#### Breaking changes

​1. Action is now stateful: If the action ends because of
[operations-per-run](https://togithub.com/actions/stale#operations-per-run)
then the next run will start from the first unprocessed issue skipping
the issues processed during the previous run(s). The state is reset when
all the issues are processed. This should be considered for scheduling
workflow runs.
2\. Version 9 of this action updated the runtime to Node.js 20. All
scripts are now run with Node.js 20 instead of Node.js 16 and are
affected by any breaking changes between Node.js 16 and 20.
​

#### What else Changed

1. Performance optimization that removes unnecessary API calls by
[@&#8203;dsame](https://togithub.com/dsame)
[#&#8203;1033](https://togithub.com/actions/stale/pull/1033/) fixes
[#&#8203;792](https://togithub.com/actions/stale/issues/792)
2. Logs displaying current github API rate limit by
[@&#8203;dsame](https://togithub.com/dsame)
[#&#8203;1032](https://togithub.com/actions/stale/pull/1032) addresses
[#&#8203;1029](https://togithub.com/actions/stale/issues/1029)
    ​\
For more information, please read the [action
documentation](https://togithub.com/actions/stale#readme) and its
[section about
statefulness](https://togithub.com/actions/stale#statefulness)

#### New Contributors

- [@&#8203;jmeridth](https://togithub.com/jmeridth) made their first
contribution in
[actions/stale#984
- [@&#8203;nikolai-laevskii](https://togithub.com/nikolai-laevskii) made
their first contribution in
[actions/stale#1020
- [@&#8203;dusan-trickovic](https://togithub.com/dusan-trickovic) made
their first contribution in
[actions/stale#1056
- [@&#8203;aparnajyothi-y](https://togithub.com/aparnajyothi-y) made
their first contribution in
[actions/stale#1110

**Full Changelog**: actions/stale@v8...v9.0.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/Hapag-Lloyd/Renovate-Global-Configuration).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy44Ny4yIiwidXBkYXRlZEluVmVyIjoiMzcuODcuMiIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
julioc-lopez pushed a commit to julioc-lopez/zk that referenced this pull request Jan 9, 2024
Bumps actions/stale from 8 to 9.

Release notes
Sourced from actions/stale's releases.

v9.0.0
Breaking Changes
Action is now stateful: If the action ends because of operations-per-run then the next run will start from the first unprocessed issue skipping the issues processed during the previous run(s). The state is reset when all the issues are processed. This should be considered for scheduling workflow runs.
Version 9 of this action updated the runtime to Node.js 20. All scripts are now run with Node.js 20 instead of Node.js 16 and are affected by any breaking changes between Node.js 16 and 20.
What Else Changed
Performance optimization that removes unnecessary API calls by @​dsame #1033 fixes #792
Logs displaying current github API rate limit by @​dsame #1032 addresses #1029
For more information, please read the action documentation and its section about statefulness

New Contributors
@​jmeridth made their first contribution in actions/stale#984
@​nikolai-laevskii made their first contribution in actions/stale#1020
@​dusan-trickovic made their first contribution in actions/stale#1056
@​aparnajyothi-y made their first contribution in actions/stale#1110
Full Changelog: actions/stale@v8...v9.0.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants