Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the stale label when labeled with an exempt one #268

Merged
merged 10 commits into from Jan 17, 2021
Merged

Remove the stale label when labeled with an exempt one #268

merged 10 commits into from Jan 17, 2021

Conversation

C0ZEN
Copy link
Contributor

@C0ZEN C0ZEN commented Jan 16, 2021 •
edited

Changes:

  • Prefix private methods with _
  • Create a new method to remove the stale label (avoid code duplication)
  • Before skipping the process when the issue/pr has an exempt label it will check if it has a stale label and remove it if it does (costing one operation)
  • Change the syntax to display the default values in italic in the readme so that prettier is no longer messing with them

Closes #136

@C0ZEN
Merge pull request #1 from actions/main
c21e2f2
@C0ZEN
Merge pull request #2 from actions/main
c913fa4
@C0ZEN
Merge pull request #3 from actions/main
9cf9bf2 
feat(stale-and-close): add new options to change the days before clos…
@C0ZEN
Merge pull request #4 from actions/main
f11f623
@C0ZEN
refactor(issue): create a dedicated function to remove the stale label
6b72954
@C0ZEN
refactor: prefix private methods with _
0e4efa3 
to make it consistent with others methods
@C0ZEN
feat(label): remove the stale label when labeled with an exempt one
b0083fa 
closes actions#136
@C0ZEN
chore: fix logger issues due to rebase
4fef0e7 
@hross I think there is a room for improvement regarding the class creation of the issue logger (code duplication) but I do not see how to do it without changing a lot of stuff; do you have an idea?
@C0ZEN
Copy link
Contributor Author

C0ZEN commented Jan 16, 2021 •
edited

@hross this is the last one from me for this week ;)
Maybe not, I am bored.

@C0ZEN C0ZEN changed the title Remove the stale label when labeled with an exempt one WIP: Remove the stale label when labeled with an exempt one Jan 16, 2021
@C0ZEN C0ZEN changed the title WIP: Remove the stale label when labeled with an exempt one Remove the stale label when labeled with an exempt one Jan 16, 2021
@C0ZEN
docs(readme): fix parsing error of the default values in the table
dbd3d0c 
prettier was not liking the previous syntax
@hross hross merged commit 7f340a4 into actions:main Jan 17, 2021
C0ZEN added a commit to C0ZEN/stale that referenced this pull request Jan 17, 2021
@C0ZEN
Merge pull request #5 from actions/main
0f1457a 
Remove the stale label when labeled with an exempt one  (actions#268)
@C0ZEN C0ZEN deleted the feature/remove-stale branch January 18, 2021 20:15
@chadwhitacre chadwhitacre mentioned this pull request Jan 19, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hross hross hross approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove stale label when issue is tagged with exempt label after marking stale
2 participants
@C0ZEN @hross