abort the build on the error #935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsame
force-pushed
the
invalid-creds2
branch
2 times, most recently
from
4d1e2fb
to
ae382cd
Compare
IvanZosimov
reviewed
Feb 13, 2023
dsame
force-pushed
the
invalid-creds2
branch
8 times, most recently
from
c584de6
to
b1cebe0
Compare
dsame
force-pushed
the
invalid-creds2
branch
2 times, most recently
from
d1d7035
to
6f4f2e2
Compare
MaksimZhukov
approved these changes
Feb 28, 2023
marko-zivic-93
approved these changes
Mar 2, 2023
IvanZosimov
approved these changes
Mar 2, 2023
5 tasks
1 task
kayman-mk
pushed a commit
to Hapag-Lloyd/Repository-Templates
that referenced
this pull request
Nov 19, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [actions/stale](https://togithub.com/actions/stale) | action | major | `v7.0.0` -> `v8.0.0` | --- ### Release Notes <details> <summary>actions/stale (actions/stale)</summary> ### [`v8.0.0`](https://togithub.com/actions/stale/releases/tag/v8.0.0) [Compare Source](https://togithub.com/actions/stale/compare/v7.0.0...v8.0.0) :warning: This version contains breaking changes :warning: #### What's Changed - New option labels-to-remove-when-stale enables users to specify list of comma delimited labels that will be removed when the issue or PR becomes stale by [@​panticmilos](https://togithub.com/panticmilos) [actions/stale#770 - Skip deleting the branch in the upstream of a forked repo by [@​dsame](https://togithub.com/dsame) [actions/stale#913 - abort the build on the error by [@​dsame](https://togithub.com/dsame) in [actions/stale#935 #### Breaking Changes - In this release we prevent scenarios when the build is not interrupted on some exceptions, which led to successful builds when they are supposed to fail #### Example ```yaml name: 'Remove labels when the issue or PR becomes stale' on: schedule: - cron: '30 1 * * *' permissions: pull-requests: write jobs: stale: runs-on: ubuntu-latest steps: - uses: actions/stale@v8 with: labels-to-remove-when-stale: 'label1,label2' ``` </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/Hapag-Lloyd/Repository-Templates). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy41OS44IiwidXBkYXRlZEluVmVyIjoiMzcuNTkuOCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
kayman-mk
pushed a commit
to Hapag-Lloyd/Renovate-Global-Configuration
that referenced
this pull request
Nov 19, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [actions/stale](https://togithub.com/actions/stale) | action | major | `v7.0.0` -> `v8.0.0` | --- ### Release Notes <details> <summary>actions/stale (actions/stale)</summary> ### [`v8.0.0`](https://togithub.com/actions/stale/releases/tag/v8.0.0) [Compare Source](https://togithub.com/actions/stale/compare/v7.0.0...v8.0.0) :warning: This version contains breaking changes :warning: #### What's Changed - New option labels-to-remove-when-stale enables users to specify list of comma delimited labels that will be removed when the issue or PR becomes stale by [@​panticmilos](https://togithub.com/panticmilos) [actions/stale#770 - Skip deleting the branch in the upstream of a forked repo by [@​dsame](https://togithub.com/dsame) [actions/stale#913 - abort the build on the error by [@​dsame](https://togithub.com/dsame) in [actions/stale#935 #### Breaking Changes - In this release we prevent scenarios when the build is not interrupted on some exceptions, which led to successful builds when they are supposed to fail #### Example ```yaml name: 'Remove labels when the issue or PR becomes stale' on: schedule: - cron: '30 1 * * *' permissions: pull-requests: write jobs: stale: runs-on: ubuntu-latest steps: - uses: actions/stale@v8 with: labels-to-remove-when-stale: 'label1,label2' ``` </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/Hapag-Lloyd/Renovate-Global-Configuration). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy41OS44IiwidXBkYXRlZEluVmVyIjoiMzcuNTkuOCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Current logic assumes the build is not interrupted on some exception. This leads the build looks succeeded while it is failed in fact.
The PR makeы the build to fail if some of them have happened.
Related issue:
link to the related issue.
Check list: