Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve PHP workflow and add PHP package workflow #222

Closed
wants to merge 2 commits into from

Conversation

ad4g
Copy link

@ad4g ad4g commented Nov 25, 2019

  • Improve PHP workflow to add support for installing extensions as most PHP projects have extensions which are not default as requirements.
  • Add a PHP package workflow to test PHP packages with different versions and supported OS.

I know you do not accept external actions here, but I have used shivammathur/setup-php in both these workflows as PHP does not have one tool to install extensions for all OS and it is difficult to maintain a workflow for different OS if one has to script to install extensions and keep track of them.

  • Does not use an Action that isn't in the actions organization. Please See Improve PHP support in starter workflows. #221
  • Does not send data to any 3rd party service except for the purposes of installing dependencies.
  • Does not use a paid service or product.

Fixes #221

Add action to setup required PHP environment.
@ethomson
Copy link
Contributor

I'm very excited to improve PHP support! However:

I know you do not accept external actions here...

That's correct, we do not. This is a hard restriction, and it's for the safety and security of the GitHub Actions platform and ecosystem. We'd like to see improvements to the actions/setup-php action to support this functionality. I'd love to see a collaboration with https://github.com/shivammathur/setup-php - that certainly seems like a sensible path forward that leverages the expertise that @shivammathur has.

But I regret that referencing actions outside the https://github.com/actions/ organization is not something that we'll include in the getting started CI workflows at the moment.

@ad4g
Copy link
Author

ad4g commented Nov 25, 2019

@ethomson Thanks for the response.
I hope you consider this PR in the future, because in its current state the PHP Composer workflow as I said is of limited use.

@MasterOdin
Copy link
Contributor

@ethomson Given the policy changes in #451, would it be possible to update this workflow then to pin shivammathur/setup-php to a sha and have this be merged?

@github-actions
Copy link

This pull request has become stale and will be closed automatically within a period of time. Sorry about that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve PHP support in starter workflows.
3 participants