Update pull_request_template.md #451
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
April 3, 2020 15:14
eregon
reviewed
Apr 6, 2020
| - [ ] Does not use a paid service or product. | ||
| - [ ] This workflow must only use actions that are produced by GitHub, [in the `actions` organization](https://github.com/actions), **or** | ||
|
|
||
| This workflow must only use actions that are produced by the language or ecosystem that the workflow supports. These actions must be [published to the GitHub Marketplace](https://github.com/marketplace?type=actions). Workflows using these actions must reference the action using the full 40 character hash of the action's commit instead of a tag. Additionally, workflows must include the following comment at the top of the workflow file: |
Contributor
There was a problem hiding this comment.
Workflows using these actions must reference the action using the full 40 character hash of the action's commit instead of a tag.
I think that part is problematic, see #448 (comment)
Contributor
Author
There was a problem hiding this comment.
Indeed, there are tradeoffs here. Given that we're running actions from third parties, we want to maximize the security for the ecosystem. Right now this means 40 character hashes. We're working on other solutions, but this is the safest mechanism at the moment.
8 tasks
This was referenced Jun 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the pull request template with stylistic and policy changes.