@actions/artifact package updates #408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
konradpabjan
commented
Apr 8, 2020
| @@ -296,3 +304,11 @@ export async function createDirectoriesForArtifact( | |||
| }) | |||
| } | |||
| } | |||
|
|
|||
| export async function createEmptyFilesForArtifact( | |||
There was a problem hiding this comment.
I followed the guidance here on how to create an empty file in node.
konradpabjan
commented
Apr 9, 2020
| // ensure they are first created by using the createDirectoriesForArtifact method | ||
| const directoryStructure = [root, directoryToCreate] | ||
| await utils.createDirectoriesForArtifact(directoryStructure) | ||
| await expect(fs.promises.access(root)).resolves.toEqual(undefined) |
There was a problem hiding this comment.
For asynchronously checking if files exist, I used this for guidance
There was a problem hiding this comment.
What's wrong with fs.existsSync?
There was a problem hiding this comment.
fs.existsSync is perfectly fine however I'm trying to use async/promises wherever possible. In general any sync operation will block the event loop until the operation is complete so asyncification is usually a good thing.
joshmgross
approved these changes
Apr 9, 2020
| // ensure they are first created by using the createDirectoriesForArtifact method | ||
| const directoryStructure = [root, directoryToCreate] | ||
| await utils.createDirectoriesForArtifact(directoryStructure) | ||
| await expect(fs.promises.access(root)).resolves.toEqual(undefined) |
There was a problem hiding this comment.
What's wrong with fs.existsSync?
yacaovsnc
approved these changes
Apr 9, 2020
at-wat
pushed a commit
to at-wat/actions-toolkit
that referenced
this pull request
Aug 31, 2023
* Clear error message when storage quota has been hit * Improved download of empty files * Extra info to RELEASES.md * PR Feedback
This was referenced Oct 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
RELEASES.mdwith changelog infopackage.jsonandpackage-lock.json403might be returned when trying to create a new container for an artifact. There is now a clear error message that lets the user know they can't upload any more artifacts because of storage. For more info, see Try out v2-preview upload-artifact#62 (comment)upload.test.tsto test a403response code along with an extra test inutil.test.tsv1action ofdownload-artifacthas some extra logic when dealing with empty files. You can find it here. The updates in the PR largely aim to replicate this behavior so there are no extra HTTP calls made when downloading empty files.download-specificationhas been updated with a newemptyFilesToCreatearray that keeps track of empty files that should be createdutil.tshas been updated with a new method that creates empty filesdownload-specificationcorrectly picks up empty files and that empty files actually get createdTesting