Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add version attribute in rule/schema/server.xml to help to identify config version #986

Closed
sunsun314 opened this issue Feb 14, 2019 · 1 comment
Closed

Add version attribute in rule/schema/server.xml to help to identify config version #986

sunsun314 opened this issue Feb 14, 2019 · 1 comment
Assignees
@wjl1619
Labels
doc-it differ with mysql, and let it go Improvement resolve problem has been fixed by developer
Milestone
2.19.01.0

Comments

@sunsun314
Copy link
Contributor

Well,when the dble-server be upgraded in some customer's environment ，there may be some errors occur because the config attribute has changed when the dble version changes. They may confused about what version the config file is and how to change to latest version config.
So we decide to add a version attribute in rule/schema/server.xml to help the user to identify the config version.DBLE would not stop user use outdated config ,only notify user with warning logs and dryrun results
@yanhuqing666 yanhuqing666 added this to the 2.19.01.0 milestone Feb 14, 2019
@sunsun314 sunsun314 mentioned this issue Feb 14, 2019
Merged
@sunsun314 sunsun314 added the doc-it differ with mysql, and let it go label Feb 18, 2019
sunsun314 added a commit that referenced this issue Feb 19, 2019
@sunsun314
#986 remove duplicate warning log
031b961
@sunsun314 sunsun314 mentioned this issue Feb 19, 2019
Merged
yanhuqing666 added a commit that referenced this issue Feb 19, 2019
@yanhuqing666
Merge pull request #1006 from actiontech/issue-986
17207bc 
#986 remove duplicate warning log
@sunsun314 sunsun314 added the resolve problem has been fixed by developer label Feb 20, 2019
@sunsun314 sunsun314 assigned wjl1619 and unassigned sunsun314 Feb 20, 2019
sunsun314 added a commit that referenced this issue Feb 20, 2019
@sunsun314
#986 add null check when try pull from zk
3e814ee
@sunsun314 sunsun314 mentioned this issue Feb 20, 2019
Merged
sunsun314 added a commit that referenced this issue Feb 20, 2019
@sunsun314
#986 add null check when try pull from zk
d14e336
yanhuqing666 added a commit that referenced this issue Feb 20, 2019
@yanhuqing666
Merge pull request #1008 from actiontech/issue-986
3a5b129 
#986 add null check when try pull from zk
@wjl1619
Copy link
Member

wjl1619 commented Feb 20, 2019

verified on dble version: 5.6.29-dble-9.9.9.9-e3b87339fe8b0d59538c27c01771ded840355091-20190220091638

@wjl1619 wjl1619 closed this as completed Feb 20, 2019
sunsun314 added a commit that referenced this issue Mar 7, 2019
@sunsun314
#986 fix upload zk version NP exception
24a7273
@sunsun314 sunsun314 mentioned this issue Mar 7, 2019
Merged
sunsun314 added a commit that referenced this issue Mar 7, 2019
@sunsun314
#986 fix upload zk version NP exception
ac93c35
yanhuqing666 pushed a commit that referenced this issue Mar 7, 2019
@sunsun314 @yanhuqing666
#986 fix upload zk version NP exception (#1043)
b691128 
* #986  fix upload zk version NP exception

* #986  fix upload zk version NP exception

* unused import delete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wjl1619 wjl1619

Labels
doc-it differ with mysql, and let it go Improvement resolve problem has been fixed by developer
Projects
None yet
Milestone
2.19.01.0
Development

No branches or pull requests
3 participants
@sunsun314 @yanhuqing666 @wjl1619