Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CPU usage #402

Closed
ghost opened this issue Feb 20, 2019 · 4 comments
Closed

CPU usage #402

ghost opened this issue Feb 20, 2019 · 4 comments

Comments

@ghost
Copy link

ghost commented Feb 20, 2019 •
edited by ghost

Watch

  • single node src+dest: 100%
  • separate src & dest: each is ~80%
  • flamegraph torch.svg.zip

Analysis

  • gob encode/decode takes CPU time
  • siddontang/go-mysql read packet -> Read
    • No new binlog data is being generated. Is it some polling?
    • DONE: re-watch the process and generate flamegraph (with SkipIncrementalCopy: true).
      • recorded in incremental process

Plan

  • replace gob with avro || ?
    • gob is 'self-describing', which is not necessary for our pre-defined structures.
@ghost
Copy link
Author

ghost commented May 13, 2019

TODO: re-watch the process and generate flamegraph (with SkipIncrementalCopy: true). @leixia2018

@ghost
Copy link
Author

ghost commented Jun 6, 2019 •
edited by ghost

Another point: consider in-place snappy (de)compressing, instead of creating new slice.

ghost pushed a commit that referenced this issue Jun 10, 2019
replace gob with gencode (#402)
ca0845e
ghost pushed a commit that referenced this issue Jun 10, 2019
kafka: adapt to gencode (#402)
b821b99
@ghost
Copy link
Author

ghost commented Jun 17, 2019

CPU usage after switching to gencode

Screen Shot 2019-06-17 at 10 45 12

Remaining point

  • EscapeValue
  • snappy

ghost pushed a commit that referenced this issue Jun 17, 2019
replace gob with gencode (#402)
66f2e93
ghost pushed a commit that referenced this issue Jun 17, 2019
kafka: adapt to gencode (#402)
65e606b
ghost pushed a commit that referenced this issue Jun 17, 2019
Merge branch '402-cpu' (#402)
d050c27
ghost pushed a commit that referenced this issue Sep 22, 2020
Merge branch 'incr-gencode'
1b9db83 
- A preliminary step for memory metrics for incremental stage.
- #402
@ghost
Copy link
Author

ghost commented Nov 25, 2020

TODO compare performance before / after 'incr-gencode' change.

@ghost ghost closed this as completed Jan 21, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
0 participants