-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rails 7 support #272
Rails 7 support #272
Conversation
@flavorjones This looks great. A few thoughts:
(as with everywhere in rubyland. thanks for the contribution) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. just minor logistics questions
@kbrock Thanks for the review and for asking these questions. This should "just work" for folks who have followed the README and are extending their AR classes with However, it looks like not all the tests were following that advice but were still passing with Rails 6 (see the change in this PR to |
Looks like the ActiveRecordExtensions module was added in v0.9.6 (see 153c58e) but wasn't added to this test (probably because it wasn't failing). |
Thanks. Ok, I change my view from breaking change to bug fix. |
@kbrock I just saw now that I still had a "wip" message in that last commit, urk, sorry, I should have fixed that. Candidly, I did not expect that code to pass on every Rails version and assumed I'd be coming back to clean something up. 🤷 |
@flavorjones ugh. very sorry that I did not see that. ping me to get that through |
Alternative implementation to #267 that doesn't monkeypatch ActiveRecord.
This implementation subclasses
ActiveRecord::Reflection::BelongsToReflection
and overrides thecompute_class
method to allow ActiveHash associations.I've also cherry-picked some relevant commits from #267.