Enables Lint/UselessAccessModifier cop (#6564)

And fix all offenses.
activeadmin · Dec 1, 2020 · 8b1a53f · 8b1a53f
1 parent 5877602
commit 8b1a53f
Show file tree

Hide file tree

Showing 5 changed files with 3 additions and 8 deletions.
diff --git a/.rubocop.yml b/.rubocop.yml
@@ -192,3 +192,6 @@ Layout/SpaceInsideHashLiteralBraces:
 
 Layout/SpaceInsideParens:
   Enabled: true
+
+Lint/UselessAccessModifier:
+  Enabled: true
diff --git a/lib/active_admin/error.rb b/lib/active_admin/error.rb
@@ -45,8 +45,6 @@ def self.capture
       raise new exception
     end
 
-    private
-
     def self.database_error_classes
       @classes ||= []
     end

diff --git a/lib/active_admin/filters/active_filter.rb b/lib/active_admin/filters/active_filter.rb
@@ -113,8 +113,6 @@ def predicate_association
         @predicate_association
       end
 
-      private
-
       def find_predicate_association
         condition_attribute.klass.reflect_on_all_associations.
           reject { |r| r.options[:polymorphic] }. #skip polymorphic

diff --git a/lib/active_admin/resource/routes.rb b/lib/active_admin/resource/routes.rb
@@ -42,8 +42,6 @@ def route_uncountable?
         config[:route_collection_name] == config[:route_instance_name]
       end
 
-      private
-
       class RouteBuilder
         def initialize(resource)
           @resource = resource

diff --git a/lib/active_admin/resource_controller/decorators.rb b/lib/active_admin/resource_controller/decorators.rb
@@ -57,8 +57,6 @@ def self.wrap(decorator)
           @cache[name] ||= wrap! collection_decorator, name
         end
 
-        private
-
         def self.wrap!(parent, name)
           ::Class.new parent do
             delegate :reorder, :page, :current_page, :total_pages, :limit_value,