Skip to content

Commit

Permalink
configure rspec with disable_monkey_patching!
Browse files Browse the repository at this point in the history
  • Loading branch information
Fivell committed Feb 18, 2017
1 parent 66b74fb commit 96b5f47
Show file tree
Hide file tree
Showing 98 changed files with 125 additions and 124 deletions.
2 changes: 1 addition & 1 deletion spec/bug_report_templates_spec.rb
@@ -1,6 +1,6 @@
require 'spec_helper'

describe 'bug_report_templates' do
RSpec.describe 'bug_report_templates' do
subject do
Bundler.with_clean_env do
Dir.chdir(chdir_path) do
Expand Down
1 change: 1 addition & 0 deletions spec/rails_helper.rb
Expand Up @@ -101,6 +101,7 @@ def with_translation(translation)
ActiveAdmin.application.current_user_method = false

RSpec.configure do |config|
config.disable_monkey_patching!
config.use_transactional_fixtures = true
config.use_instantiated_fixtures = false
config.render_views = false
Expand Down
40 changes: 20 additions & 20 deletions spec/requests/default_namespace_spec.rb
@@ -1,6 +1,6 @@
require 'rails_helper'

describe ActiveAdmin::Application, type: :request do
RSpec.describe ActiveAdmin::Application, type: :request do

include Rails.application.routes.url_helpers

Expand Down Expand Up @@ -33,29 +33,29 @@

end

describe "with a test default namespace" do
describe "with a test default namespace" do

before(:all) do
@__original_application = ActiveAdmin.application
application = ActiveAdmin::Application.new
application.default_namespace = :test
ActiveAdmin.application = application
load_defaults!
reload_routes!
end

after(:all) do
ActiveAdmin.application = @__original_application
end
before(:all) do
@__original_application = ActiveAdmin.application
application = ActiveAdmin::Application.new
application.default_namespace = :test
ActiveAdmin.application = application
load_defaults!
reload_routes!
end

it "should generate a log out path" do
expect(destroy_admin_user_session_path).to eq "/test/logout"
end
after(:all) do
ActiveAdmin.application = @__original_application
end

it "should generate a log in path" do
expect(new_admin_user_session_path).to eq "/test/login"
end
it "should generate a log out path" do
expect(destroy_admin_user_session_path).to eq "/test/logout"
end

it "should generate a log in path" do
expect(new_admin_user_session_path).to eq "/test/login"
end

end

end
2 changes: 1 addition & 1 deletion spec/requests/javascript_spec.rb
Expand Up @@ -7,7 +7,7 @@
RbConfig::CONFIG['host_os'].include?('darwin') ? `/usr/libexec/java_home` : `which java`
java_installed = $?.success?

describe 'Javascript', type: :request, if: java_installed do
RSpec.describe 'Javascript', type: :request, if: java_installed do
let(:lint) {
JSLint::Lint.new \
paths: ['public/javascripts/**/*.js'],
Expand Down
2 changes: 1 addition & 1 deletion spec/requests/memory_spec.rb
@@ -1,6 +1,6 @@
require 'rails_helper'

describe "Memory Leak", type: :request, if: RUBY_ENGINE == 'ruby' do
RSpec.describe "Memory Leak", type: :request, if: RUBY_ENGINE == 'ruby' do
def count_instances_of(klass)
ObjectSpace.each_object(klass) { }
end
Expand Down
2 changes: 1 addition & 1 deletion spec/requests/stylesheets_spec.rb
@@ -1,6 +1,6 @@
require 'rails_helper'

describe "Stylesheets", type: :request do
RSpec.describe "Stylesheets", type: :request do

require "sprockets"

Expand Down
2 changes: 1 addition & 1 deletion spec/unit/abstract_view_factory_spec.rb
Expand Up @@ -2,7 +2,7 @@

require 'active_admin/abstract_view_factory'

describe ActiveAdmin::AbstractViewFactory do
RSpec.describe ActiveAdmin::AbstractViewFactory do

let(:view_factory){ ActiveAdmin::AbstractViewFactory.new }
let(:view){ Class.new }
Expand Down
2 changes: 1 addition & 1 deletion spec/unit/action_builder_spec.rb
@@ -1,6 +1,6 @@
require 'rails_helper'

describe 'defining actions from registration blocks', type: :controller do
RSpec.describe 'defining actions from registration blocks', type: :controller do
let(:klass){ Admin::PostsController }
render_views # https://github.com/rspec/rspec-rails/issues/860

Expand Down
2 changes: 1 addition & 1 deletion spec/unit/active_admin_spec.rb
@@ -1,6 +1,6 @@
require 'rails_helper'

describe ActiveAdmin do
RSpec.describe ActiveAdmin do
%w(register register_page unload! load! routes).each do |method|
it "delegates ##{method} to application" do
expect(ActiveAdmin.application).to receive(method)
Expand Down
4 changes: 2 additions & 2 deletions spec/unit/application_spec.rb
@@ -1,11 +1,11 @@
require 'rails_helper'
require 'fileutils'

describe ActiveAdmin::Application do
RSpec.describe ActiveAdmin::Application do

let(:application) do
ActiveAdmin::Application.new.tap do |app|
# Manually override the load paths becuase RSpec messes these up
# Manually override the load paths becuase RSpec.messes these up
app.load_paths = [File.expand_path('app/admin', Rails.root)]
end
end
Expand Down
2 changes: 1 addition & 1 deletion spec/unit/asset_registration_spec.rb
@@ -1,6 +1,6 @@
require 'rails_helper'

describe ActiveAdmin::AssetRegistration do
RSpec.describe ActiveAdmin::AssetRegistration do
include ActiveAdmin::AssetRegistration

before do
Expand Down
2 changes: 1 addition & 1 deletion spec/unit/authorization/authorization_adapter_spec.rb
@@ -1,6 +1,6 @@
require 'rails_helper'

describe ActiveAdmin::AuthorizationAdapter do
RSpec.describe ActiveAdmin::AuthorizationAdapter do

let(:adapter) { ActiveAdmin::AuthorizationAdapter.new(double, double) }

Expand Down
2 changes: 1 addition & 1 deletion spec/unit/authorization/controller_authorization_spec.rb
@@ -1,7 +1,7 @@
require 'rails_helper'
Auth = ActiveAdmin::Authorization

describe Admin::PostsController, "Controller Authorization", type: :controller do
RSpec.describe Admin::PostsController, "Controller Authorization", type: :controller do

let(:authorization){ controller.send(:active_admin_authorization) }

Expand Down
2 changes: 1 addition & 1 deletion spec/unit/authorization/index_overriding_spec.rb
@@ -1,6 +1,6 @@
require 'rails_helper'

describe Admin::PostsController, 'Index overriding', type: :controller do
RSpec.describe Admin::PostsController, 'Index overriding', type: :controller do
before do
controller.instance_eval do
def index
Expand Down
2 changes: 1 addition & 1 deletion spec/unit/auto_link_spec.rb
@@ -1,6 +1,6 @@
require 'rails_helper'

describe "auto linking resources" do
RSpec.describe "auto linking resources" do
include ActiveAdmin::ViewHelpers::ActiveAdminApplicationHelper
include ActiveAdmin::ViewHelpers::AutoLinkHelper
include ActiveAdmin::ViewHelpers::DisplayHelper
Expand Down
2 changes: 1 addition & 1 deletion spec/unit/batch_actions/resource_spec.rb
@@ -1,6 +1,6 @@
require 'rails_helper'

describe ActiveAdmin::BatchActions::ResourceExtension do
RSpec.describe ActiveAdmin::BatchActions::ResourceExtension do

let(:resource) do
namespace = ActiveAdmin::Namespace.new(ActiveAdmin::Application.new, :admin)
Expand Down
2 changes: 1 addition & 1 deletion spec/unit/batch_actions/settings_spec.rb
@@ -1,6 +1,6 @@
require 'rails_helper'

describe "Batch Actions Settings" do
RSpec.describe "Batch Actions Settings" do
let(:app) { ActiveAdmin::Application.new }
let(:ns) { ActiveAdmin::Namespace.new(app, "Admin") }
let(:post_resource) { ns.register Post }
Expand Down
2 changes: 1 addition & 1 deletion spec/unit/belongs_to_spec.rb
@@ -1,6 +1,6 @@
require 'rails_helper'

describe ActiveAdmin::Resource::BelongsTo do
RSpec.describe ActiveAdmin::Resource::BelongsTo do

let(:user_config){ ActiveAdmin.register User }
let(:post_config){ ActiveAdmin.register Post do belongs_to :user end }
Expand Down
2 changes: 1 addition & 1 deletion spec/unit/cancan_adapter_spec.rb
@@ -1,6 +1,6 @@
require 'rails_helper'

describe ActiveAdmin::CanCanAdapter do
RSpec.describe ActiveAdmin::CanCanAdapter do

describe "full integration" do

Expand Down
2 changes: 1 addition & 1 deletion spec/unit/comments_spec.rb
@@ -1,6 +1,6 @@
require 'rails_helper'

describe "Comments" do
RSpec.describe "Comments" do
let(:application) { ActiveAdmin::Application.new }

describe ActiveAdmin::Comment do
Expand Down
2 changes: 1 addition & 1 deletion spec/unit/component_spec.rb
Expand Up @@ -2,7 +2,7 @@

class MockComponentClass < ActiveAdmin::Component; end

describe ActiveAdmin::Component do
RSpec.describe ActiveAdmin::Component do

let(:component_class){ MockComponentClass }
let(:component){ component_class.new }
Expand Down
4 changes: 2 additions & 2 deletions spec/unit/config_shared_examples.rb
@@ -1,4 +1,4 @@
shared_examples_for "ActiveAdmin::Resource" do
RSpec.shared_examples_for "ActiveAdmin::Resource" do
describe "namespace" do
it "should return the namespace" do
expect(config.namespace).to eq(namespace)
Expand Down Expand Up @@ -58,7 +58,7 @@
end
end

shared_examples_for "ActiveAdmin::Localizers::ResourceLocalizer" do
RSpec.shared_examples_for "ActiveAdmin::Localizers::ResourceLocalizer" do
it "should use proper translation" do
string = ActiveAdmin::Localizers::ResourceLocalizer.t(action, model: model, model_name: model_name)
expect(string).to eq translation
Expand Down
2 changes: 1 addition & 1 deletion spec/unit/controller_filters_spec.rb
@@ -1,6 +1,6 @@
require 'rails_helper'

describe ActiveAdmin::Application do
RSpec.describe ActiveAdmin::Application do
let(:application){ ActiveAdmin::Application.new }
let(:controllers){ application.controllers_for_filters }

Expand Down
2 changes: 1 addition & 1 deletion spec/unit/csv_builder_spec.rb
Expand Up @@ -2,7 +2,7 @@

require 'rails_helper'

describe ActiveAdmin::CSVBuilder do
RSpec.describe ActiveAdmin::CSVBuilder do

describe '.default_for_resource using Post' do
let(:csv_builder) { ActiveAdmin::CSVBuilder.default_for_resource(Post).tap(&:exec_columns) }
Expand Down
2 changes: 1 addition & 1 deletion spec/unit/dependency_spec.rb
@@ -1,6 +1,6 @@
require 'rails_helper'

describe ActiveAdmin::Dependency do
RSpec.describe ActiveAdmin::Dependency do

k = ActiveAdmin::Dependency

Expand Down
2 changes: 1 addition & 1 deletion spec/unit/devise_spec.rb
@@ -1,6 +1,6 @@
require 'rails_helper'

describe ActiveAdmin::Devise::Controller do
RSpec.describe ActiveAdmin::Devise::Controller do

let(:controller_class) do
klass = Class.new do
Expand Down
2 changes: 1 addition & 1 deletion spec/unit/dsl_spec.rb
Expand Up @@ -6,7 +6,7 @@ def self.included(dsl)
end
end

describe ActiveAdmin::DSL do
RSpec.describe ActiveAdmin::DSL do

let(:application) { ActiveAdmin::Application.new }
let(:namespace) { ActiveAdmin::Namespace.new application, :admin }
Expand Down
4 changes: 2 additions & 2 deletions spec/unit/filters/active_spec.rb
@@ -1,6 +1,6 @@
require 'rails_helper'

describe ActiveAdmin::Filters::Active do
RSpec.describe ActiveAdmin::Filters::Active do
subject { described_class.new(Post, params) }
let(:params_klass) do
if defined? ::ActionController::Parameters
Expand All @@ -18,4 +18,4 @@
expect(subject.filters.size).to eq(1)
end

end
end
2 changes: 1 addition & 1 deletion spec/unit/filters/filter_form_builder_spec.rb
Expand Up @@ -12,7 +12,7 @@ class Post
end
end

describe ActiveAdmin::Filters::ViewHelper do
RSpec.describe ActiveAdmin::Filters::ViewHelper do

# Setup an ActionView::Base object which can be used for
# generating the form for.
Expand Down
2 changes: 1 addition & 1 deletion spec/unit/filters/humanized_spec.rb
@@ -1,6 +1,6 @@
require 'rails_helper'

describe ActiveAdmin::Filters::Humanized do
RSpec.describe ActiveAdmin::Filters::Humanized do
describe '#value' do
it 'should equal query string parameter if not an Array' do
param = ['category_id_eq', '1']
Expand Down
2 changes: 1 addition & 1 deletion spec/unit/filters/resource_spec.rb
@@ -1,6 +1,6 @@
require 'rails_helper'

describe ActiveAdmin::Filters::ResourceExtension do
RSpec.describe ActiveAdmin::Filters::ResourceExtension do

let(:resource) do
namespace = ActiveAdmin::Namespace.new(ActiveAdmin::Application.new, :admin)
Expand Down
2 changes: 1 addition & 1 deletion spec/unit/form_builder_spec.rb
@@ -1,7 +1,7 @@
require 'rails_helper'
require "rspec/mocks/standalone"

describe ActiveAdmin::FormBuilder do
RSpec.describe ActiveAdmin::FormBuilder do
# Setup an ActionView::Base object which can be used for
# generating the form for.
let(:helpers) do
Expand Down
2 changes: 1 addition & 1 deletion spec/unit/generators/install_spec.rb
@@ -1,6 +1,6 @@
require 'rails_helper'

describe "AA installation" do
RSpec.describe "AA installation" do
context "should create" do

it "active_admin.scss" do
Expand Down
2 changes: 1 addition & 1 deletion spec/unit/helpers/collection_spec.rb
@@ -1,6 +1,6 @@
require 'rails_helper'

describe ActiveAdmin::Helpers::Collection do
RSpec.describe ActiveAdmin::Helpers::Collection do

include ActiveAdmin::Helpers::Collection

Expand Down
2 changes: 1 addition & 1 deletion spec/unit/helpers/scope_chain_spec.rb
@@ -1,6 +1,6 @@
require 'rails_helper'

describe ActiveAdmin::ScopeChain do
RSpec.describe ActiveAdmin::ScopeChain do

include ActiveAdmin::ScopeChain

Expand Down
2 changes: 1 addition & 1 deletion spec/unit/helpers/settings_spec.rb
@@ -1,7 +1,7 @@
require 'rails_helper'
require 'active_admin/helpers/settings'

describe ActiveAdmin::Settings do
RSpec.describe ActiveAdmin::Settings do

# A Class with settings module included
let(:klass) do
Expand Down
2 changes: 1 addition & 1 deletion spec/unit/i18n_spec.rb
@@ -1,7 +1,7 @@
require 'rails_helper'

Dir.glob('config/locales/*.yml') do |locale_file|
describe locale_file do
RSpec.describe locale_file do
it { is_expected.to be_parseable }
it { is_expected.to have_one_top_level_namespace }
it { is_expected.to be_named_like_top_level_namespace }
Expand Down
2 changes: 1 addition & 1 deletion spec/unit/localizers/resource_localizer_spec.rb
@@ -1,7 +1,7 @@
require 'spec_helper'
require File.expand_path('../config_shared_examples', File.dirname(__FILE__))

describe ActiveAdmin::Localizers::ResourceLocalizer do
RSpec.describe ActiveAdmin::Localizers::ResourceLocalizer do
let(:action) { 'new_model' }
let(:model) { 'Comment' }
let(:model_name) { 'comment' }
Expand Down
2 changes: 1 addition & 1 deletion spec/unit/menu_collection_spec.rb
@@ -1,6 +1,6 @@
require 'rails_helper'

describe ActiveAdmin::MenuCollection do
RSpec.describe ActiveAdmin::MenuCollection do

let(:menus) { ActiveAdmin::MenuCollection.new }

Expand Down

0 comments on commit 96b5f47

Please sign in to comment.