Problem with the undecorate option for the new form

[dmfrancisco]

According to the docs, if a resource is decorated, the instance provided to form_for also gets decorated. However, this does not seem to be the case for the new action.

Since passing the decorated instance to forms may cause problems (as explained in the docs), I need to use decorate: false, which internally calls model to return the undecorated instance. It works for edits, but raises an "undefined method 'model' error" for the new action.

module ActiveAdmin
  module ViewHelpers
    module FormHelper
      def active_admin_form_for(resource, options = {}, &block)
        options = Marshal.load( Marshal.dump(options) )
        options[:builder] ||= ActiveAdmin::FormBuilder

        if ! options.fetch(:decorate, true)
          resource = resource.model # <= This line causes the error
        end

        semantic_form_for resource, options, &block
      end
    end
  end
end

Something like:

resource = resource.respond_to?(:model) ? resource.model : resource

Prevents the exception from being raised, but does not fix the problem, which is the instantiated object is not decorated. Thanks for this awesome gem 👍

---

Note: I already added the fix for Draper +1.1 as explained in the wiki. I'm using AA from master and tested with Draper 1.0.0, 1.1.0 and 1.2.1.

[seanlinsley]

I don't understand why it wouldn't respond to model only on the new action... Any thoughts?

[dmfrancisco]

This was a long time ago. At that time, I monkey patched active_admin_form_for like I explained above. Since I'm not using AA anymore, I don't know if this was fixed in the meantime. It seems no one has reported similar issues, so I guess you can close this.

Thank you again for your time, and for the excellent work in pushing this gem forward.
I hope I get to use it again in future projects 👍

[seanlinsley]

Okay, well at any rate thanks for the quick response. I'm trying to clean up the issue tracker so it's easier to manage.

Hopefully you do :]

[aldesantis]

I'm experiencing this with master on Rails 4. On the "new" page I get an "Undefined method model" error, so for the time being I've just put the following in my model:

def model
  self
end

It'd be nice to see this fixed. :)

[seanlinsley]

Can you try debugging, and finding out what type of object model is trying to be called on in each situation?

[aldesantis]

I'm sorry, what do you mean exactly by "type of object"?

[seanlinsley]

I meant answering the question: if the resource object isn't a decoration, what is it?

Hmm, I guess there's no point anyway. It seems pretty clear that the 'new' form's object simply isn't decorated. It'd be nice to know for sure though.

[aldesantis]

Oh, the resource is just an object of the model class.

[rgalindo33]

Im having the same issue, is this solved?

[grzegorzblaszczyk]

Not yet, I will go back to this during the weekend...